Minor changes to previously merged PR

mrblackfree · Mar 24, 2018 · 2434a74 · 2434a74
1 parent 6c78b56
commit 2434a74
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/etc/translations/strings.xml b/etc/translations/strings.xml
@@ -196,6 +196,7 @@
     <string name="filter_archived">Hide archived notes</string>
     <string name="remove_filter_archived">Show archived notes</string>
     <string name="permission_external_storage">Permission to write on external storage is needed to allow backups on public folders</string>
+    <string name="permission_external_storage_detail_attachment">Permission to read on external storage is needed to allow read content from public folders</string>
     <string name="permission_audio_recording">Permission to use microphone is needed  to record audio notes</string>
     <string name="permission_coarse_location">Permission to access to location is needed to add position informations to your notes</string>
     <string name="permission_not_granted">Permission not granted</string>

diff --git a/omniNotes/src/main/java/it/feio/android/omninotes/DetailFragment.java b/omniNotes/src/main/java/it/feio/android/omninotes/DetailFragment.java
@@ -128,7 +128,7 @@ public class DetailFragment extends BaseFragment implements OnReminderPickedList
 	private static final int CATEGORY = 5;
 	private static final int DETAIL = 6;
 	private static final int FILES = 7;
-	private final int RC_READ_EXTERNAL_STORAGE_PERMISSION = 1;
+	private static final int RC_READ_EXTERNAL_STORAGE_PERMISSION = 1;
 
 	@BindView(R.id.detail_root)
 	ViewGroup root;
@@ -2380,10 +2380,12 @@ public void onClick(View v) {
 				case R.id.files:
 					if (ContextCompat.checkSelfPermission(getActivity(),
 							Manifest.permission.READ_EXTERNAL_STORAGE)
-							== PackageManager.PERMISSION_GRANTED)
+							== PackageManager.PERMISSION_GRANTED) {
 						startGetContentAction();
-					else
+					}
+					else {
 						askReadExternalStoragePermission();
+					}
 					attachmentDialog.dismiss();
 					break;
 				case R.id.sketch:

diff --git a/omniNotes/src/main/res/values/strings.xml b/omniNotes/src/main/res/values/strings.xml
@@ -209,7 +209,7 @@
     <string name="filter_archived">Hide archived notes</string>
     <string name="remove_filter_archived">Show archived notes</string>
     <string name="permission_external_storage">Permission to write on external storage is needed to allow backups on public folders</string>
-    <string name="permission_external_storage_detail_attachment">Permission to write on external storage is needed to allow read content from public folders</string>
+    <string name="permission_external_storage_detail_attachment">Permission to read on external storage is needed to allow read content from public folders</string>
     <string name="permission_audio_recording">Permission to use microphone is needed  to record audio notes</string>
     <string name="permission_coarse_location">Permission to access to location is needed to add position informations to your notes</string>
     <string name="permission_not_granted">Permission not granted</string>