Add option to only catch intentionally raised exceptions#36
Open
moshimeow wants to merge 2 commits intomsamogh:masterfrom
Open
Add option to only catch intentionally raised exceptions#36moshimeow wants to merge 2 commits intomsamogh:masterfrom
moshimeow wants to merge 2 commits intomsamogh:masterfrom
Conversation
6ebe1cc to
95a1e10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So there might be a simpler way to do this, but:
I have a dataset where I weed out bad samples through heuristics/geometry and explicitly raise an error when one of the checks doesn't pass. Then as I was hacking on it I got really confused before I realized "doh, Nonechucks is catching all my exceptions!"
So this is my solution: add an option where it'll only not raise an error if it gets a NoneChucksSkipException. This solution probably sucks, and if you want to reject it and say "no, do Y instead" I'd love to hear it