Update test and is_array check for optional actions

mtolhuys · Mar 6, 2020 · c701d24 · c701d24
1 parent 3a3fdf1
commit c701d24
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Http/Controllers/Traits/HasOptionalActions.php b/src/Http/Controllers/Traits/HasOptionalActions.php
@@ -16,7 +16,7 @@ trait HasOptionalActions
      */
     public function optionalActions($request)
     {
-        if (! isset($request['actions'])) {
+        if (! is_array($request['actions'])) {
             return;
         }
 

diff --git a/tests/Feature/ModelsControllerTest.php b/tests/Feature/ModelsControllerTest.php
@@ -57,14 +57,16 @@ public function tearDown(): void
 
     /** @test
      * @throws ReflectionException
+     * @throws \Illuminate\Contracts\Filesystem\FileNotFoundException
      */
     public function it_successfully_creates_models_with_all_optional_actions()
     {
         (new ModelsController())->create(new CreateModelRequest([
             'name' => 'Wombat',
             'fields' => $this->fields,
             'actions' => [
-                'hasResource' => 'true',
+                'hasModelMigration' => 'true',
+                'hasResourceController' => 'true',
                 'hasFormRequest' => 'true',
             ],
         ]));
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,7 +16,7 @@ trait HasOptionalActions @@
          */
         public function optionalActions($request)
         {
-            if (! isset($request['actions'])) {
+            if (! is_array($request['actions'])) {
                 return;
             }
@@ Expand Down @@