fix: make linter happy

.github/workflows/lint-soft.yml

@@ -0,0 +1,23 @@
+name: lint-soft
+on:
+  push:
+  pull_request:
+
+permissions:
+  contents: read
+  # Optional: allow read access to pull request. Use with `only-new-issues` option.
+  pull-requests: read
+
+jobs:
+  golangci:
+    name: lint-soft
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v3
+        with:
+          # Optional: golangci-lint command line arguments.
+          args: --config .golangci-soft.yml --issues-exit-code=0
+          # Optional: show only new issues if it's a pull request. The default value is `false`.
+          only-new-issues: true

.github/workflows/lint.yml

@@ -3,20 +3,21 @@ on:
   push:
   pull_request:
 
+permissions:
+  contents: read
+  # Optional: allow read access to pull request. Use with `only-new-issues` option.
+  pull-requests: read
+
 jobs:
   golangci:
     name: lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v2
+        uses: golangci/golangci-lint-action@v3
         with:
-          # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
-          version: v1.30
           # Optional: golangci-lint command line arguments.
-          args: --issues-exit-code=0
-          # Optional: working directory, useful for monorepos
-          # working-directory: somedir
+          #args:
           # Optional: show only new issues if it's a pull request. The default value is `false`.
           only-new-issues: true

.golangci-soft.yml

@@ -0,0 +1,47 @@
+run:
+  tests: false
+
+issues:
+  include:
+    - EXC0001
+    - EXC0005
+    - EXC0011
+    - EXC0012
+    - EXC0013
+
+  max-issues-per-linter: 0
+  max-same-issues: 0
+
+linters:
+  enable:
+    # - dupl
+    - exhaustive
+    # - exhaustivestruct
+    - goconst
+    - godot
+    - godox
+    - gomnd
+    - gomoddirectives
+    - goprintffuncname
+    - ifshort
+    # - lll
+    - misspell
+    - nakedret
+    - nestif
+    - noctx
+    - nolintlint
+    - prealloc
+    - wrapcheck
+
+  # disable default linters, they are already enabled in .golangci.yml
+  disable:
+    - deadcode
+    - errcheck
+    - gosimple
+    - govet
+    - ineffassign
+    - staticcheck
+    - structcheck
+    - typecheck
+    - unused
+    - varcheck

.golangci.yml

@@ -2,24 +2,28 @@ run:
   tests: false
 
 issues:
+  include:
+    - EXC0001
+    - EXC0005
+    - EXC0011
+    - EXC0012
+    - EXC0013
+
   max-issues-per-linter: 0
   max-same-issues: 0
 
 linters:
   enable:
     - bodyclose
-    - dupl
     - exportloopref
-    - goconst
-    - godot
-    - godox
     - goimports
-    - goprintffuncname
     - gosec
-    - misspell
-    - prealloc
+    - nilerr
+    - predeclared
+    - revive
     - rowserrcheck
     - sqlclosecheck
+    - tparallel
     - unconvert
     - unparam
     - whitespace

gists.go

@@ -13,7 +13,7 @@ var gistsQuery struct {
 			TotalCount githubv4.Int
 			Edges      []struct {
 				Cursor githubv4.String
-				Node   QLGist
+				Node   qlGist
 			}
 		} `graphql:"gists(first: $count, orderBy: {field: CREATED_AT, direction: DESC})"`
 	} `graphql:"user(login:$username)"`
@@ -34,7 +34,7 @@ func gists(count int) []Gist {
 
 	// fmt.Printf("%+v\n", query)
 	for _, v := range gistsQuery.User.Gists.Edges {
-		gists = append(gists, GistFromQL(v.Node))
+		gists = append(gists, gistFromQL(v.Node))
 	}
 
 	// fmt.Printf("Found %d gists!\n", len(gists))

main.go

@@ -93,7 +93,7 @@ func main() {
 			fmt.Println("Can't create:", err)
 			os.Exit(1)
 		}
-		defer f.Close()
+		defer f.Close() //nolint: errcheck
 		w = f
 	}
 

repos.go

@@ -21,7 +21,7 @@ var recentContributionsQuery struct {
 						}
 					}
 				} `graphql:"contributions(first: 1)"`
-				Repository QLRepository
+				Repository qlRepository
 			} `graphql:"commitContributionsByRepository(maxRepositories: 100)"`
 		}
 	} `graphql:"user(login:$username)"`
@@ -34,7 +34,7 @@ var recentPullRequestsQuery struct {
 			TotalCount githubv4.Int
 			Edges      []struct {
 				Cursor githubv4.String
-				Node   QLPullRequest
+				Node   qlPullRequest
 			}
 		} `graphql:"pullRequests(first: $count, orderBy: {field: CREATED_AT, direction: DESC})"`
 	} `graphql:"user(login:$username)"`
@@ -47,7 +47,7 @@ var recentReposQuery struct {
 			TotalCount githubv4.Int
 			Edges      []struct {
 				Cursor githubv4.String
-				Node   QLRepository
+				Node   qlRepository
 			}
 		} `graphql:"repositories(first: $count, privacy: PUBLIC, isFork: false, ownerAffiliations: OWNER, orderBy: {field: CREATED_AT, direction: DESC})"`
 	} `graphql:"user(login:$username)"`
@@ -61,8 +61,8 @@ var recentReleasesQuery struct {
 			Edges      []struct {
 				Cursor githubv4.String
 				Node   struct {
-					QLRepository
-					Releases QLRelease `graphql:"releases(first: 10, orderBy: {field: CREATED_AT, direction: DESC})"`
+					qlRepository
+					Releases qlRelease `graphql:"releases(first: 10, orderBy: {field: CREATED_AT, direction: DESC})"`
 				}
 			}
 		} `graphql:"repositoriesContributedTo(first: 100, after:$after includeUserRepositories: true, contributionTypes: COMMIT, privacy: PUBLIC)"`
@@ -91,7 +91,7 @@ func recentContributions(count int) []Contribution {
 		}
 
 		c := Contribution{
-			Repo:       RepoFromQL(v.Repository),
+			Repo:       repoFromQL(v.Repository),
 			OccurredAt: v.Contributions.Edges[0].Node.OccurredAt.Time,
 		}
 
@@ -131,7 +131,7 @@ func recentPullRequests(count int) []PullRequest {
 			continue
 		}
 
-		pullRequests = append(pullRequests, PullRequestFromQL(v.Node))
+		pullRequests = append(pullRequests, pullRequestFromQL(v.Node))
 		if len(pullRequests) == count {
 			break
 		}
@@ -160,7 +160,7 @@ func recentRepos(count int) []Repo {
 			continue
 		}
 
-		repos = append(repos, RepoFromQL(v.Node))
+		repos = append(repos, repoFromQL(v.Node))
 		if len(repos) == count {
 			break
 		}
@@ -192,7 +192,7 @@ func recentReleases(count int) []Repo {
 		}
 
 		for _, v := range recentReleasesQuery.User.RepositoriesContributedTo.Edges {
-			r := RepoFromQL(v.Node.QLRepository)
+			r := repoFromQL(v.Node.qlRepository)
 
 			for _, rel := range v.Node.Releases.Nodes {
 				if rel.IsPrerelease || rel.IsDraft {
@@ -202,15 +202,15 @@ func recentReleases(count int) []Repo {
 					v.Node.Releases.Nodes[0].PublishedAt.Time.IsZero() {
 					continue
 				}
-				r.LastRelease = ReleaseFromQL(v.Node.Releases)
+				r.LastRelease = releaseFromQL(v.Node.Releases)
 				break
 			}
 
 			if !r.LastRelease.PublishedAt.IsZero() {
 				repos = append(repos, r)
 			}
 
-			after = &v.Cursor
+			after = githubv4.NewString(v.Cursor)
 		}
 	}
 

rss.go

@@ -6,6 +6,7 @@ import (
 	"github.com/mmcdole/gofeed"
 )
 
+// RSSEntry represents a single RSS entry.
 type RSSEntry struct {
 	Title       string
 	URL         string

sponsors.go

@@ -17,8 +17,8 @@ var sponsorsQuery struct {
 					CreatedAt     githubv4.DateTime
 					SponsorEntity struct {
 						Typename     githubv4.String `graphql:"__typename"`
-						User         QLUser          `graphql:"... on User"`
-						Organization QLUser          `graphql:"... on Organization"`
+						User         qlUser          `graphql:"... on User"`
+						Organization qlUser          `graphql:"... on Organization"`
 					}
 				}
 			}
@@ -45,12 +45,12 @@ func sponsors(count int) []Sponsor {
 		switch v.Node.SponsorEntity.Typename {
 		case "User":
 			sponsors = append(sponsors, Sponsor{
-				User:      UserFromQL(v.Node.SponsorEntity.User),
+				User:      userFromQL(v.Node.SponsorEntity.User),
 				CreatedAt: v.Node.CreatedAt.Time,
 			})
 		case "Organization":
 			sponsors = append(sponsors, Sponsor{
-				User:      UserFromQL(v.Node.SponsorEntity.Organization),
+				User:      userFromQL(v.Node.SponsorEntity.Organization),
 				CreatedAt: v.Node.CreatedAt.Time,
 			})
 		}

stars.go

@@ -14,7 +14,7 @@ var recentStarsQuery struct {
 			Edges      []struct {
 				Cursor    githubv4.String
 				StarredAt githubv4.DateTime
-				Node      QLRepository
+				Node      qlRepository
 			}
 		} `graphql:"starredRepositories(first: $count, orderBy: {field: STARRED_AT, direction: DESC})"`
 	} `graphql:"user(login:$username)"`
@@ -34,7 +34,7 @@ func recentStars(count int) []Star {
 	for _, v := range recentStarsQuery.User.Stars.Edges {
 		starredRepos = append(starredRepos, Star{
 			StarredAt: v.StarredAt.Time,
-			Repo:      RepoFromQL(v.Node),
+			Repo:      repoFromQL(v.Node),
 		})
 	}