Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#176] Basic unit tests #347

Merged
merged 9 commits into from
Aug 6, 2024
Merged

[nasa/nos3#176] Basic unit tests #347

merged 9 commits into from
Aug 6, 2024

Conversation

jlucas9
Copy link
Contributor

@jlucas9 jlucas9 commented Jul 31, 2024

@jlucas9
Copy link
Contributor Author

jlucas9 commented Aug 1, 2024

To test this I did the following:

cd ~/Downloads
git clone https://github.com/nasa/nos3.git
cd nos3
git checkout nos3#176-unit-tests
git submodule update --init --recursive
make real-clean
make prep
make debug
make clean config build-test test-fsw

Confirmed tests passed manually at the end. Unfortunately, some tests may fail depending on the resources in your environment.

Copy link
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran with a NOS3 virtual machine, things appear to all work; it has errors and failed tests when running on just a regular machine, though.

@jlucas9
Copy link
Contributor Author

jlucas9 commented Aug 5, 2024

When I ran with a NOS3 virtual machine, things appear to all work; it has errors and failed tests when running on just a regular machine, though.

Was able to replicate. Simply running make test-fsw again has it passing which is fun. Thinking we approve this for new and create a new issue to resolve this.

@jlucas9 jlucas9 mentioned this pull request Aug 6, 2024
Copy link

@zlynch2 zlynch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running 1 test fails out of 150. Seems to mostly work, I may be missing something small. Also I re-ran twice with make test-fsw and go the same result

image

@dccutrig
Copy link

dccutrig commented Aug 6, 2024

My comment is similar. First time two tests failed, reran and one test failed.

Copy link
Contributor

@Donnie-Ice Donnie-Ice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed for me

@jlucas9 jlucas9 merged commit 1c0de00 into dev Aug 6, 2024
4 checks passed
@jlucas9 jlucas9 deleted the nos3#176-unit-tests branch August 6, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants