Review and publish Open MCT Style Guide v1 #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1233 Theme-based styling added; significant mods to layout; Content for controls page;
Fixes #1233 Additional content; tweak to H3 margins
Fixes #1233 Additional content; tweak to H3 margins
Fixes #1233 Additional content; adding size classes to input[type="text"] to allow direct application to the input; added placeholder styling and related thematic constants.
Fixes #1233 Add major new content, glyphs page and display code; minor layout tweaks;
Fixes #1233 Mods to core CSS for consistency
Fixes #1233 More glyphs content: usage, guidelines, etc.
Fixes #1233 Adds to text inputs content; Mods to MCTExample to allow a padded wrapper around <pre> element; Fixed snow theme css file reference;
Fixes #1233 Style-guide thematic color constants added; Normalized doc-title content across files; Additional detail in glyphs.html;
Fixes #1233 Modified platform global font-weight and input font usage for legibility;
Fixes #1233 Fix Style Guide tree elements to no longer render as links;
Fixes #1233 More content
Fixes #1233 More content; table styling
Fixes #1233 Refactoring to generalize plot styles
Fixes #1233 Added colors page content and display code; Added conditional hide/show per theme;
Fixes #1233 Tweak to color swatch shape
Fixes #1233 Update glyphs data from symbols spreadsheet to pull in new expand glyph and reflect minor organizational changes;
Fixes #1233 Todo: Need to fix page types
|
Charles to reintegrate with master, and then reassign for review and merge with master. After that, we need to open an issue to export this and publish it on the website. |
|
@VWoeltjen Sorry, thought I'd done the merge and fix already. Will take a look now. |
|
Woot! Circleci is happy, therefore I am happy. |
VWoeltjen
approved these changes
May 2, 2017
Reviewer Checklist
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1 of the Style Guide is ready to be published. For #1233.
Author Checklist