Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Licenses] Update copyright year to 2017 #1518

Merged
merged 2 commits into from
Apr 24, 2017
Merged

[Licenses] Update copyright year to 2017 #1518

merged 2 commits into from
Apr 24, 2017

Conversation

VWoeltjen
Copy link
Contributor

Fixes #1517

Used find <dir> -type f -exec sed -i "" s/"Open MCT, Copyright (c) 2014-2016"/"Open MCT, Copyright (c) 2014-2017"/g {} \; for each relevant directory, and a similar sed at the top-level. This had the unintended side effect of introducing trailing newlines in all files, but that just makes our code style more consistent, so I'm thinking that's okay.

Author Checklist

  1. Changes address original issue? Y
  2. Unit tests included and/or updated with changes? Y (their license headers, at least!)
  3. Command line build passes? Y
  4. Changes have been smoke-tested? Y

@VWoeltjen VWoeltjen added this to the Stross milestone Apr 5, 2017
@VWoeltjen VWoeltjen requested a review from akhenry April 5, 2017 22:08
@akhenry
Copy link
Contributor

akhenry commented Apr 24, 2017

Looks good to me. Review method:

  1. Diff commits, and produce file with just line changes

    git diff -U0 185567c^1 185567c | grep '^[+-]' | grep -Ev '^(--- a/|\+\+\+ b/)' > diff.csv
    
  2. Escape all lines with quotes for handling in Excel

    awk '{ print "\""$0"\""}' diff.csv > diff.quotes.csv
    
  3. Opened diff.quotes.csv in Excel. Used "Remove duplicates" feature to produce list of unique changes which was then reviewed.

  4. Reviewed 0cbbeef by hand

Reviewer Checklist

  • Changes appear to address issue? Y
  • Appropriate unit tests included? N/A comments only
  • Code style and in-line documentation are appropriate? N/A
  • Commit messages meet standards? Y

@akhenry akhenry merged commit ec4fe8e into master Apr 24, 2017
@akhenry akhenry deleted the copyright-1517 branch April 24, 2017 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants