Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and integrate usage of new Import/Export glyphs #1735

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Review and integrate usage of new Import/Export glyphs #1735

merged 1 commit into from
Sep 25, 2017

Conversation

charlesh88
Copy link
Contributor

Fixes #1695. Updated to use new glyphs.

Author Checklist

  1. Changes address original issue? Y
  2. Unit tests included and/or updated with changes? N/A
  3. Command line build passes? Y
  4. Changes have been smoke-tested? Y

prestonjcrowe
prestonjcrowe approved these changes Sep 25, 2017
View reviewed changes
Copy link
Contributor

@prestonjcrowe prestonjcrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Have smoke tested these changes on my machine.

@VWoeltjen
Copy link
Contributor

Reviewer Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? N/A
  3. Code style and in-line documentation are appropriate? Y
  4. Commit messages meet standards? Y

@VWoeltjen VWoeltjen merged commit bfa3bbc into master Sep 25, 2017
@VWoeltjen VWoeltjen deleted the import-export-1695 branch September 25, 2017 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonjcrowe prestonjcrowe prestonjcrowe approved these changes

@VWoeltjen VWoeltjen Awaiting requested review from VWoeltjen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlesh88 @VWoeltjen @prestonjcrowe