Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install Chart plugin by default #5163

Merged
merged 7 commits into from
May 24, 2022
Merged

Do not install Chart plugin by default #5163

merged 7 commits into from
May 24, 2022

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented May 5, 2022

Closes #5088

Describe your changes:

Do not install the Chart plugin by default in MCT.js, but add it to the list of plugins installed when running in development mode (e.g. npm start workflow).

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx requested a review from akhenry May 5, 2022 16:24
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #5163 (91d0973) into master (405418b) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5163      +/-   ##
==========================================
- Coverage   50.27%   50.17%   -0.10%     
==========================================
  Files         548      548              
  Lines       20129    20127       -2     
  Branches     1864     1864              
==========================================
- Hits        10119    10098      -21     
- Misses       9526     9551      +25     
+ Partials      484      478       -6     
Impacted Files Coverage Δ
src/MCT.js 97.80% <ø> (-0.05%) ⬇️
...lugins/plot/overlayPlot/OverlayPlotViewProvider.js 14.28% <0.00%> (-78.58%) ⬇️
src/plugins/charts/bar/plugin.js 71.42% <0.00%> (-28.58%) ⬇️
src/ui/inspector/InspectorViews.vue 64.28% <0.00%> (-28.58%) ⬇️
...ugins/plot/inspector/PlotsInspectorViewProvider.js 64.28% <0.00%> (-28.58%) ⬇️
...Conductor/independent/IndependentTimeConductor.vue 0.00% <0.00%> (-28.13%) ⬇️
src/plugins/plot/Plot.vue 38.46% <0.00%> (-23.08%) ⬇️
src/plugins/plot/inspector/PlotOptions.vue 80.00% <0.00%> (-20.00%) ⬇️
...rts/bar/inspector/BarGraphInspectorViewProvider.js 81.81% <0.00%> (-9.10%) ⬇️
...tter/inspector/ScatterPlotInspectorViewProvider.js 81.81% <0.00%> (-9.10%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 405418b...91d0973. Read the comment docs.

@akhenry
Copy link
Contributor

akhenry commented May 20, 2022

Looks great, thank you @ozyx !

@akhenry akhenry enabled auto-merge (squash) May 20, 2022 19:17
@akhenry akhenry self-requested a review May 23, 2022 20:46
@akhenry akhenry merged commit 2d73296 into master May 24, 2022
@ozyx ozyx deleted the mct5088 branch June 6, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not install Bar Chart plugin by default
2 participants