-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operator status #5179
Operator status #5179
Conversation
- New icon glyph - IMPORTANT: OVERRIDE ANY MERGE CONFLICTS USING THIS COMMIT!
- WIP on OperatorStatus styling.
- Fixed erroneous font glyph mapping;
- Added default color for indicator icon;
Todos@akhenry
|
- Changed user indicator to display response when set to other than "NO_STATUS". - Standardized icon display.
… is the most full and complete version of the symbols font - OVERRIDE ANY MERGE CONFLICTS WITH THIS COMMIT!
Implementation Notes
openmct.install(openmct.plugins.example.ExampleUser({
autoLoginUser: 'guest',
defaultStatusRole: 'Driver'
}));
openmct.install(openmct.plugins.OperatorStatus()); |
Codecov Report
@@ Coverage Diff @@
## master #5179 +/- ##
==========================================
- Coverage 50.28% 50.15% -0.13%
==========================================
Files 548 556 +8
Lines 20133 20393 +260
Branches 1866 1876 +10
==========================================
+ Hits 10123 10229 +106
- Misses 9514 9677 +163
+ Partials 496 487 -9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really solid! Nicely done!
I'm curious, what is the expected behavior if the same user is logged in on multiple tabs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Closes #5193
Describe your changes:
Operator status functionality for managing and responding to operations status polls questions.
To Do
@charlesh88
@akhenry
All Submissions:
Author Checklist
Reviewer Checklist