Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable lint enforcement on e2e tests and fix the existing errors #5229

Merged
merged 4 commits into from
May 19, 2022

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented May 19, 2022

Closes #5124

Describe your changes:

We have rules defined for linting our e2e tests, but we weren't actually running eslint against the e2e folder. As a result, local and CI runs of npm run lint were not picking up any incoming rule violations.

This PR adds the e2e folder to our npm lint scripts and either fixes or excepts all of the "new" errors.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx requested review from akhenry and unlikelyzero May 19, 2022 22:30
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #5229 (f5612e0) into master (85fce3c) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5229      +/-   ##
==========================================
+ Coverage   50.07%   50.18%   +0.11%     
==========================================
  Files         546      546              
  Lines       20071    20071              
  Branches     1859     1859              
==========================================
+ Hits        10050    10073      +23     
+ Misses       9543     9513      -30     
- Partials      478      485       +7     
Impacted Files Coverage Δ
src/plugins/imagery/components/ImageryView.vue 33.83% <ø> (ø)
src/ui/inspector/details/Properties.vue 61.40% <0.00%> (-14.04%) ⬇️
src/ui/inspector/Location.vue 59.37% <0.00%> (-3.13%) ⬇️
src/plugins/timeConductor/ConductorHistory.vue 48.93% <0.00%> (-2.13%) ⬇️
src/plugins/duplicate/DuplicateAction.js 31.91% <0.00%> (-2.13%) ⬇️
src/plugins/move/MoveAction.js 52.11% <0.00%> (-1.41%) ⬇️
src/ui/router/Browse.js 86.48% <0.00%> (-1.36%) ⬇️
...c/plugins/persistence/couch/CouchObjectProvider.js 82.22% <0.00%> (+0.44%) ⬆️
src/api/time/IndependentTimeContext.js 81.57% <0.00%> (+1.31%) ⬆️
src/api/composition/CompositionCollection.js 88.04% <0.00%> (+2.17%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85fce3c...f5612e0. Read the comment docs.

@ozyx ozyx merged commit 6521b88 into master May 19, 2022
@ozyx ozyx deleted the mct5124-enable-e2e-lint branch May 19, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Enable lint enforcement on e2e suite
2 participants