Enable lint enforcement on e2e tests and fix the existing errors #5229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5124
Describe your changes:
We have rules defined for linting our e2e tests, but we weren't actually running eslint against the
e2e
folder. As a result, local and CI runs ofnpm run lint
were not picking up any incoming rule violations.This PR adds the
e2e
folder to our npm lint scripts and either fixes or excepts all of the "new" errors.All Submissions:
Author Checklist
Reviewer Checklist