Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc UI 4843 better Edit mode #5496

Closed
wants to merge 8 commits into from
Closed

Misc UI 4843 better Edit mode #5496

wants to merge 8 commits into from

Conversation

charlesh88
Copy link
Contributor

@charlesh88 charlesh88 commented Jul 13, 2022

Describe your changes:

  • Restored sub-object c-frame-edit behavior.
  • Smoke tested with nested Display Layouts, Flex Layouts and Tabs View containing Display Layouts.
  • New look for editing mode.
  • Better approach to main pane while editing.
  • Suppressed Snapshot while editing for clarity.
  • Added labels to main view Edit and Save buttons.
  • Remove type-icon special case font sizing;
  • Remove Firefox-specific scrollbar-width: thin for Ubuntu display.
  • Mod to edit lock button title.

Testing notes in related issue #4843.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

- Restored sub-object `c-frame-edit` behavior;
- Smoke tested with nested Display Layouts, Flex Layouts and Tabs View containing Display Layouts;
- Added labels to main view Edit and Save buttons;
- New look for editing mode;
- Better approach to main pane while editing;
- Suppressed Snapshot while editing for clarity;
- WIP, needs cleanups;
- symbols font changed from 20% baseline height to 10%;
- Remove type-icon special case font sizing;
- Remove Firefox-specific `scrollbar-width: thin` for Ubuntu display;
- Mod to edit lock button title.
- Sanding and shimming for enhanced Edit mode look-and-feel.
- Cleanup, remove commented CSS.
# Conflicts:
#	src/styles/_constants-espresso.scss
#	src/styles/_constants-maelstrom.scss
#	src/styles/fonts/Open-MCT-Symbols-16px.svg
#	src/styles/fonts/Open-MCT-Symbols-16px.ttf
#	src/styles/fonts/Open-MCT-Symbols-16px.woff
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #5496 (2ccf706) into master (2fa36b2) will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5496      +/-   ##
==========================================
- Coverage   54.33%   54.01%   -0.33%     
==========================================
  Files         598      598              
  Lines       22956    22953       -3     
  Branches     2078     2077       -1     
==========================================
- Hits        12474    12398      -76     
- Misses       9906     9973      +67     
- Partials      576      582       +6     
Flag Coverage Δ *Carryforward flag
e2e-ci 39.49% <ø> (ø) Carriedforward from 2fa36b2
e2e-full 51.23% <ø> (ø) Carriedforward from 2fa36b2
e2e-stable 36.08% <ø> (-12.66%) ⬇️
unit 50.33% <ø> (-0.41%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
src/ui/layout/BrowseBar.vue 46.42% <ø> (-0.70%) ⬇️
.../telemetryTable/components/table-configuration.vue 0.00% <0.00%> (-43.25%) ⬇️
src/ui/inspector/InspectorViews.vue 64.28% <0.00%> (-28.58%) ⬇️
src/plugins/displayLayout/plugin.js 79.59% <0.00%> (-12.25%) ⬇️
...c/plugins/telemetryTable/components/sizing-row.vue 38.88% <0.00%> (-11.12%) ⬇️
...lemetryTable/components/table-footer-indicator.vue 26.41% <0.00%> (-9.44%) ⬇️
src/plugins/plot/configuration/SeriesCollection.js 61.53% <0.00%> (-6.16%) ⬇️
src/plugins/telemetryTable/components/table.vue 41.40% <0.00%> (-4.51%) ⬇️
src/ui/components/ObjectView.vue 46.19% <0.00%> (-4.35%) ⬇️
src/ui/inspector/Inspector.vue 75.00% <0.00%> (-4.17%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fa36b2...2ccf706. Read the comment docs.

@charlesh88 charlesh88 mentioned this pull request Mar 6, 2023
8 tasks
@charlesh88
Copy link
Contributor Author

Closing this PR for now; notes in issue #4843.

@charlesh88 charlesh88 closed this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant