-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc UI 4843 better Edit mode #5496
Conversation
- Restored sub-object `c-frame-edit` behavior; - Smoke tested with nested Display Layouts, Flex Layouts and Tabs View containing Display Layouts;
- Added labels to main view Edit and Save buttons;
- New look for editing mode; - Better approach to main pane while editing; - Suppressed Snapshot while editing for clarity; - WIP, needs cleanups;
- symbols font changed from 20% baseline height to 10%; - Remove type-icon special case font sizing; - Remove Firefox-specific `scrollbar-width: thin` for Ubuntu display;
# Conflicts: # src/styles/_constants-espresso.scss # src/styles/_constants-maelstrom.scss # src/styles/fonts/Open-MCT-Symbols-16px.svg # src/styles/fonts/Open-MCT-Symbols-16px.ttf # src/styles/fonts/Open-MCT-Symbols-16px.woff
Codecov Report
@@ Coverage Diff @@
## master #5496 +/- ##
==========================================
- Coverage 54.33% 54.01% -0.33%
==========================================
Files 598 598
Lines 22956 22953 -3
Branches 2078 2077 -1
==========================================
- Hits 12474 12398 -76
- Misses 9906 9973 +67
- Partials 576 582 +6
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
Closing this PR for now; notes in issue #4843. |
Describe your changes:
c-frame-edit
behavior.scrollbar-width: thin
for Ubuntu display.Testing notes in related issue #4843.
All Submissions:
Author Checklist
Reviewer Checklist