Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compass rose rotation fixes #6260

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Compass rose rotation fixes #6260

merged 2 commits into from
Feb 3, 2023

Conversation

charlesh88
Copy link
Contributor

@charlesh88 charlesh88 commented Feb 2, 2023

Closes #6257

  • Moved rotation styling into new <g> element that holds both cam FOV and vrover element.
  • Removed this.north from camGimbalAngleStyle computed value.
  • Code cleanup.

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

- Moved rotation styling into new `<g>` element that holds
both cam FOV and `vrover` element.
- Removed `this.north` from `camGimbalAngleStyle` computed value.
- Code cleanup.
@charlesh88 charlesh88 added this to the Target:2.1.6 milestone Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #6260 (f082da5) into master (800062d) will decrease coverage by 1.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6260      +/-   ##
==========================================
- Coverage   55.43%   54.26%   -1.17%     
==========================================
  Files         607      607              
  Lines       26090    26088       -2     
  Branches     2376     2376              
==========================================
- Hits        14462    14157     -305     
- Misses      10966    11263     +297     
- Partials      662      668       +6     
Flag Coverage Δ *Carryforward flag
e2e-ci 39.49% <ø> (ø) Carriedforward from 800062d
e2e-full 51.23% <ø> (ø) Carriedforward from 800062d
e2e-stable 43.43% <ø> (-10.48%) ⬇️
unit 49.73% <0.00%> (-0.44%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...plugins/imagery/components/Compass/CompassRose.vue 0.00% <0.00%> (ø)
src/plugins/operatorStatus/plugin.js 0.00% <0.00%> (-100.00%) ⬇️
...eratorStatus/pollQuestion/PollQuestionIndicator.js 0.00% <0.00%> (-100.00%) ⬇️
...orStatus/operatorStatus/OperatorStatusIndicator.js 0.00% <0.00%> (-100.00%) ⬇️
.../plugins/operatorStatus/AbstractStatusIndicator.js 0.00% <0.00%> (-93.75%) ⬇️
.../plugins/charts/scatter/ScatterPlotViewProvider.js 18.18% <0.00%> (-81.82%) ⬇️
src/api/user/StatusAPI.js 40.25% <0.00%> (-44.16%) ⬇️
.../telemetryTable/components/table-configuration.vue 0.00% <0.00%> (-43.25%) ⬇️
example/exampleUser/ExampleUserProvider.js 39.06% <0.00%> (-29.69%) ⬇️
src/plugins/linkAction/LinkAction.js 53.33% <0.00%> (-29.34%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800062d...f082da5. Read the comment docs.

@davetsay davetsay self-requested a review February 3, 2023 01:12
@davetsay davetsay marked this pull request as ready for review February 3, 2023 01:12
@davetsay davetsay merged commit 422b7f3 into master Feb 3, 2023
@davetsay davetsay deleted the compass-rose-6257 branch February 3, 2023 01:18
davetsay pushed a commit that referenced this pull request Feb 3, 2023
ozyx pushed a commit that referenced this pull request Feb 3, 2023
Compass rose rotation fixes (#6260)

Co-authored-by: Charles Hacskaylo <[email protected]>
@davetsay davetsay restored the compass-rose-6257 branch February 8, 2023 18:12
@davetsay davetsay deleted the compass-rose-6257 branch February 8, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compass rose isn't being transformed properly
2 participants