-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLA Approved] Add returns after JSDoc comments for consistency #7505
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7505 +/- ##
==========================================
+ Coverage 55.36% 55.38% +0.02%
==========================================
Files 671 671
Lines 27010 27010
Branches 2631 2631
==========================================
+ Hits 14954 14960 +6
+ Misses 11333 11327 -6
Partials 723 723
*This pull request uses carry forward flags. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
6b67ab7
to
d633667
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
Would you mind updating the linting/prettier rules to make this standardized?
@leonden Expanding on what @unlikelyzero mentioned here, we would prefer a change that enforces this as a linting or formatting rule across the codebase rather than a single PR changing one file. If that's possible to achieve, we would consider it. Could you also please do the following:
Thanks! |
@ozyx I can do that. |
@leonden |
Hi @leonden: Good news! Your CLA has been processed and approved. |
The changes made in this commit are not tied to a specific issue. I simply added returns to some JSDoc comments for a better consistency inside of the file MCT.js.