-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#7456): allow children of Overlay Plots to be removed #7516
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7516 +/- ##
==========================================
- Coverage 55.36% 55.13% -0.24%
==========================================
Files 671 672 +1
Lines 27013 27026 +13
Branches 2633 2634 +1
==========================================
- Hits 14957 14900 -57
- Misses 11332 11400 +68
- Partials 724 726 +2
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments
…o empty in a way that preserves reactivity
Closes #7456
Describe your changes:
The StalenessMixin assumes that it will always be passed a
domainObject
when looking to unsubscribe from staleness. However, in the case of Overlay Plots, it receives an Identifier directly, causing an error. This modifies that logic to check if its an Identifier first before attempting to extract an Identifier from the object.objectUtils
to have ESM exports of individual helper functionsobjectUtils
helper functions to use ESM importsAll Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist