-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Mission Status and more #7521
Conversation
"module": "esnext", | ||
"moduleResolution": "node", | ||
"outDir": "dist", | ||
"skipLibCheck": true, | ||
"target": "ES2015", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Target modern ES with our Typescript type generation
ViewRegistry.prototype.get = function (item, objectPath) { | ||
if (objectPath === undefined) { | ||
throw 'objectPath must be provided to get applicable views for an object'; | ||
export default class ViewRegistry extends EventEmitter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conversion to ES6 class
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7521 +/- ##
==========================================
- Coverage 55.43% 55.15% -0.28%
==========================================
Files 672 672
Lines 26961 26956 -5
Branches 2620 2620
==========================================
- Hits 14946 14868 -78
- Misses 11297 11368 +71
- Partials 718 720 +2
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a non-technical, looking-at-copy point of view: LGTM.
634aeef
to
57a3d90
Compare
57a3d90
to
c5fcc79
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7521 +/- ##
==========================================
- Coverage 56.31% 55.15% -1.16%
==========================================
Files 672 672
Lines 27119 26956 -163
Branches 2632 2620 -12
==========================================
- Hits 15272 14868 -404
+ Misses 11519 11368 -151
- Partials 328 720 +392
... and 264 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Closes #7520
Describe your changes:
Updates JSDoc types and documents the Mission Status feature. Also adds some docs for User API and UserIndicator where appropriate.
Updates primitive types in JSDocs to be lowercase (
string
,number
), and non-primitive to be uppercase (Object
)All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist