-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Supermenu Enhancements #7537
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7537 +/- ##
=======================================
Coverage 56.14% 56.14%
=======================================
Files 672 672
Lines 27128 27128
Branches 2635 2635
=======================================
Hits 15232 15232
+ Misses 11569 11568 -1
- Partials 327 328 +1
see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@rukmini-bose @charlesh88 this has existing test coverage in the time conductor test |
Per discussion today, let's change the code to call the menu Vue component instead of the supermenu for the mode and clock menus when we're on a mobile device. |
Sidenote, but there's a bit more work to be done in the TimeConductor area. I'm working on a prototype composable for calculating popup position across the board. The TimeConductor currently does its own popup calculations. Also, the SuperMenu component should (ideally) be dynamic enough to realize the size of the screen and adjust accordingly for mobile. Currently none of our Menus are reactive and only update once dismissed and mounted again. We will want to move towards full reactivity in order to achieve this dynamic sizing for mobile Clarification: none of the above affects this PR. I am old man yelling at cloud right now |
Took myself off as a reviewer while this is draft to get it off my radar; put me back on when it's ready. |
Closes #7536
Describe your changes:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist