Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Supermenu Enhancements #7537

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

rukmini-bose
Copy link
Contributor

@rukmini-bose rukmini-bose commented Feb 29, 2024

Closes #7536

Describe your changes:

  1. Change the height and width of supermenus such that they are smaller, yet a constant size.
  2. Remove the ability for there to be descriptions for supermenus.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes Notable Change ? For example, will this break compatibility with existing APIs or projects which source these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.14%. Comparing base (b2b0837) to head (cc069d7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7537   +/-   ##
=======================================
  Coverage   56.14%   56.14%           
=======================================
  Files         672      672           
  Lines       27128    27128           
  Branches     2635     2635           
=======================================
  Hits        15232    15232           
+ Misses      11569    11568    -1     
- Partials      327      328    +1     
Flag Coverage Δ
e2e-full 23.57% <ø> (-0.01%) ⬇️
e2e-stable 59.91% <ø> (+0.01%) ⬆️
unit 49.10% <ø> (-0.01%) ⬇️

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b0837...cc069d7. Read the comment docs.

@unlikelyzero unlikelyzero self-requested a review March 8, 2024 19:41
@unlikelyzero
Copy link
Collaborator

@rukmini-bose @charlesh88 this has existing test coverage in the time conductor test

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 19, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 19, 2024
@akhenry akhenry self-requested a review March 19, 2024 20:55
@ozyx ozyx removed this from the Target:4.0.0 milestone Mar 19, 2024
@akhenry akhenry removed their request for review March 19, 2024 20:55
@charlesh88
Copy link
Contributor

Per discussion today, let's change the code to call the menu Vue component instead of the supermenu for the mode and clock menus when we're on a mobile device.

@ozyx
Copy link
Contributor

ozyx commented Mar 24, 2024

Per discussion today, let's change the code to call the menu Vue component instead of the supermenu for the mode and clock menus when we're on a mobile device.

Sidenote, but there's a bit more work to be done in the TimeConductor area. I'm working on a prototype composable for calculating popup position across the board. The TimeConductor currently does its own popup calculations. Also, the SuperMenu component should (ideally) be dynamic enough to realize the size of the screen and adjust accordingly for mobile. Currently none of our Menus are reactive and only update once dismissed and mounted again. We will want to move towards full reactivity in order to achieve this dynamic sizing for mobile

Clarification: none of the above affects this PR. I am old man yelling at cloud right now

@rukmini-bose rukmini-bose marked this pull request as draft March 25, 2024 17:47
@charlesh88 charlesh88 removed their request for review March 28, 2024 17:09
@charlesh88
Copy link
Contributor

Took myself off as a reviewer while this is draft to get it off my radar; put me back on when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mobile Support] Supermenus need some tweaking
4 participants