Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#7015): Generate source maps for generating code coverage metrics #7582

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Mar 12, 2024

Closes #7015

Describe your changes:

Turns out you need source maps to be generated if you want to generate coverage metrics. Who'dathunkit

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.05%. Comparing base (5f0bd10) to head (31e6978).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7582      +/-   ##
==========================================
+ Coverage   55.34%   56.05%   +0.70%     
==========================================
  Files         672      672              
  Lines       27060    27094      +34     
  Branches     2626     2624       -2     
==========================================
+ Hits        14977    15188     +211     
- Misses      11360    11584     +224     
+ Partials      723      322     -401     
Flag Coverage Δ
e2e-full 23.60% <ø> (ø)
e2e-stable 59.70% <ø> (-0.03%) ⬇️
unit 49.14% <ø> (+0.72%) ⬆️

see 242 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f0bd10...31e6978. Read the comment docs.

@ozyx ozyx requested a review from unlikelyzero March 12, 2024 17:37
@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Mar 12, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Mar 12, 2024
@ozyx ozyx marked this pull request as ready for review March 12, 2024 17:38
@ozyx ozyx changed the title maybe fix code coverage fix(#7015): Generate source maps for generating code coverage metrics Mar 12, 2024
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 12, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 12, 2024
@unlikelyzero unlikelyzero enabled auto-merge (squash) March 13, 2024 00:02
@unlikelyzero unlikelyzero merged commit cb4c59a into master Mar 13, 2024
32 of 39 checks passed
@unlikelyzero unlikelyzero deleted the maybe-fix-coverage branch March 13, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code Coverage] Codecov.io reports appear to be mostly broken
2 participants