Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry Tables] Don't mutate configuration if object is not able to be persisted #7626

Merged
merged 10 commits into from
Apr 4, 2024
Merged

[Telemetry Tables] Don't mutate configuration if object is not able to be persisted #7626

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4a40e0a
source maps
jvigliotta Mar 19, 2024
c762583
do not persist if obj is not persistable
jvigliotta Mar 19, 2024
e9aeaef
nope
jvigliotta Mar 19, 2024
115d422
prevent mutation of configuration
jvigliotta Mar 19, 2024
ec991fe
static roots are read only by nature
jvigliotta Mar 19, 2024
7aa0b18
helps to use functions correctly
jvigliotta Mar 19, 2024
d8a41ff
update persistModeChange logic
jvigliotta Mar 19, 2024
a65ffc8
remove debug
jvigliotta Mar 20, 2024
f72ddf7
remove unnecessary change
jvigliotta Mar 20, 2024
6d53e85
Merge branch 'master' into static-table-performance
akhenry Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update persistModeChange logic
  • Loading branch information
@jvigliotta
jvigliotta committed Mar 19, 2024
commit d8a41ffd1f49293b422099032feaaf03e4af6513
5 changes: 3 additions & 2 deletions src/plugins/telemetryTable/TelemetryTableConfiguration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,9 @@ export default class TelemetryTableConfiguration extends EventEmitter {
// anything that doesn't have a telemetryMode existed before the change and should
// take the properties of any passed in defaults or the defaults from the plugin
configuration.telemetryMode = configuration.telemetryMode ?? this.defaultOptions.telemetryMode;
configuration.persistModeChange =
configuration.persistModeChange ?? this.defaultOptions.persistModeChange;
configuration.persistModeChange = this.notPersistable
? false
: configuration.persistModeChange ?? this.defaultOptions.persistModeChange;
configuration.rowLimit = configuration.rowLimit ?? this.defaultOptions.rowLimit;

return configuration;
Expand Down