Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time conductor refactor #7818

Draft
wants to merge 47 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
eeb4f99
add missing licensing comment
davetsay Apr 15, 2024
31be2cb
use vue component naming convention
davetsay Apr 15, 2024
c8f8a09
script, template, style
davetsay Apr 16, 2024
f56a8a1
Revert "script, template, style"
davetsay Apr 16, 2024
ff605a0
create useTimeSystem composable
davetsay Apr 16, 2024
10457a5
Merge branch 'master' into time-conductor-options
davetsay Apr 17, 2024
eeda4c6
forgot to push useTimeSystem
davetsay Apr 17, 2024
d0a7763
extend useTimeSystem to return reactive formatters
davetsay Apr 17, 2024
a11fcc3
return reactive isUTCBased
davetsay Apr 17, 2024
5adc86c
add useTimeMode composable
davetsay Apr 17, 2024
15126fd
add useTimeBounds composable
davetsay Apr 17, 2024
e624821
add useClockOffsets composable
davetsay Apr 18, 2024
00c9d29
WIP change replication in time api calls to use composables
davetsay Apr 19, 2024
2c55945
missed file in commit
davetsay Apr 19, 2024
4f37d95
use composables for conductor mode
davetsay May 1, 2024
3788a13
create useClock composable
davetsay May 14, 2024
23e12fa
whoops. mistook prettier red squiggly for code not used red squiggly.
davetsay May 14, 2024
bd1c7d9
vue naming convention
davetsay May 14, 2024
852ee74
change composables to allow for timeContexts
davetsay May 16, 2024
11adbd2
change timeContexts to be reactive to objectPath
davetsay May 17, 2024
0776003
reactivity and non fixes
davetsay May 18, 2024
5dba73e
use `shallowRef` for clock object
davetsay May 21, 2024
1bb49ea
WIP: get independent time contexts working again
davetsay May 22, 2024
9a57792
vue component naming conventions
davetsay May 22, 2024
e479c91
WIP: mostly fixed independent time conductor
davetsay May 22, 2024
9e56a22
provide timecontext even if its the global/timeapi for shared components
davetsay Jun 5, 2024
0168f92
incorporate provided timecontext into independant time conductor comp…
davetsay Jun 6, 2024
a029982
better jsdoc message
davetsay Jun 6, 2024
0254367
fix missing clock on independent time mode change
davetsay Jun 6, 2024
0cbdbc6
switch to reactive formatter for zoom
davetsay Jun 6, 2024
f349390
use reactive timecontext in fixed inputs
davetsay Jun 6, 2024
1aa3097
use reactive clock props
davetsay Jun 11, 2024
1d77368
edit for clarity
davetsay Jul 3, 2024
7ace3d0
remove unused injection
davetsay Jul 3, 2024
f1cf12d
change ITC to use composables
davetsay Jul 3, 2024
b3c99ae
update to use composables
davetsay Jul 3, 2024
fbf145c
rename because need both datetime and time inputs
davetsay Jul 3, 2024
eb314a6
make message universal to all timeSystems
davetsay Jul 11, 2024
9924f53
only change time options if independent conductor enabled
davetsay Jul 11, 2024
9065158
make date time only for supporting time systems
davetsay Jul 11, 2024
e2092a7
fix css for bounds single inputs
davetsay Jul 12, 2024
3922ade
time formats can specify date/time delimiters
davetsay Jul 12, 2024
5037254
move history out of form
davetsay Aug 21, 2024
6db96df
handle toggle independent time
davetsay Aug 21, 2024
760ca40
Merge branch 'master' into time-conductor-options-4.0.0
davetsay Aug 22, 2024
211272c
v-if logic one component up
davetsay Aug 22, 2024
140184e
add back date selector
davetsay Nov 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make message universal to all timeSystems
  • Loading branch information
davetsay committed Jul 11, 2024
commit eb314a6fabe40dce4bccbe78a885ab376de8a05d
2 changes: 1 addition & 1 deletion src/api/time/TimeContext.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ class TimeContext extends EventEmitter {
} else if (bounds.start > bounds.end) {
return {
valid: false,
message: 'Specified start date exceeds end bound'
message: 'Start bound exceeds end bound'
};
}

Expand Down