Extend conditional #7851
Extend conditional #7851
Conversation
… for historical conditional telemetry queries to allow for plotting
| @@ -243,6 +243,7 @@ export default { | |||
| domainObject: { | |||
| ...this.childObject, | |||
| configuration: { | |||
| ...this.childObject.configuration, | |||
There was a problem hiding this comment.
Fixes a bug with stacked plots
| @@ -94,7 +94,7 @@ export function ticks(start, stop, count) { | |||
| } | |||
|
|
|||
| export function commonPrefix(a, b) { | |||
| const maxLen = Math.min(a.length, b.length); | |||
| const maxLen = Math.min(a.length, b?.length); | |||
There was a problem hiding this comment.
Fixes an issue with undefined telemetry in plots
| @@ -110,7 +110,7 @@ export function commonPrefix(a, b) { | |||
| } | |||
|
|
|||
| export function commonSuffix(a, b) { | |||
| const maxLen = Math.min(a.length, b.length); | |||
| const maxLen = Math.min(a.length, b?.length); | |||
| const conditionDetails = conditionCollectionMap.get(id); | ||
| const { isDefault } = conditionDetails; | ||
| const conditionConfiguration = conditionDetails?.configuration; | ||
| const { outputTelemetry, outputMetadata, output } = conditionConfiguration; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
| const conditionDetails = conditionCollectionMap.get(id); | ||
| const { isDefault } = conditionDetails; | ||
| const conditionConfiguration = conditionDetails?.configuration; | ||
| const { outputTelemetry, outputMetadata, output } = conditionConfiguration; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
| const outputTelemetryList = []; | ||
| const domainObject = this.conditionSetDomainObject; | ||
| outputTelemetryMap.forEach((outputMetadata, timestamp) => { | ||
| const { condition, telemetry, value } = outputMetadata; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## conditional-style-performance #7851 +/- ##
=================================================================
- Coverage 58.78% 50.14% -8.65%
=================================================================
Files 675 435 -240
Lines 27277 13767 -13510
Branches 2671 0 -2671
=================================================================
- Hits 16034 6903 -9131
+ Misses 11195 6864 -4331
+ Partials 48 0 -48
... and 439 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Just want to say its great to see a PR by @khalidadil again, 🥲 |
Thanks Dave! Still got some bugs to iron out and it needs tests, but it's getting there! |
| export default class HistoricalTelemetryProvider { | ||
| constructor(openmct, telemetryObjects, conditions, conditionSetDomainObject) { | ||
| this.openmct = openmct; | ||
| this.telemetryObjects = telemetryObjects; |
There was a problem hiding this comment.
we should consider using TelemetryCollections in here to manage the input telemetry
There was a problem hiding this comment.
@khalidadil good stuff! some weirdness about leaving the plot and coming back:
Screen.Recording.2024-09-25.at.13.35.49.mov
it looks like it works on new data coming in, but not on historical data per se. Note "Enable Historical" is turned on in the clip.
Closes
Describe your changes:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist