Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't persist current tab when display is locked #7882

Merged
merged 11 commits into from
Oct 11, 2024
Merged

Don't persist current tab when display is locked #7882

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
feccc33
Check if a tabs view object is locked before persisting the default t…
shefalijoshi Oct 10, 2024
95dcf28
Add tests
shefalijoshi Oct 10, 2024
6731ecf
Merge branch 'master' into fix-persistent-tabs-immutable-displays
akhenry Oct 10, 2024
5309b69
Add a check for persistability in addition to locked
shefalijoshi Oct 10, 2024
65b16ce
Merge branch 'fix-persistent-tabs-immutable-displays' of https://gith…
shefalijoshi Oct 10, 2024
0e8b4db
Merge branch 'master' into fix-persistent-tabs-immutable-displays
shefalijoshi Oct 10, 2024
d56ad79
Revert change to check persistability
shefalijoshi Oct 10, 2024
1d9bab8
Fix test
shefalijoshi Oct 10, 2024
c3fb73f
Merge branch 'master' into fix-persistent-tabs-immutable-displays
shefalijoshi Oct 10, 2024
4b7905f
Fixed test that was broken by change in master
akhenry Oct 11, 2024
30913e2
Fix test broken by changes in master
akhenry Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed test that was broken by change in master
  • Loading branch information
@akhenry
akhenry committed Oct 11, 2024
commit 4b7905f1e5ba96ee24d913d8d041ae8408d2ac13
4 changes: 2 additions & 2 deletions e2e/tests/functional/plugins/tabs/tabs.e2e.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ test.describe('Tabs View', () => {
}) => {
await page.goto(tabsView.url);
//lock the view
await page.getByLabel('Unlocked for editing - click to lock.', { exact: true }).click();
await page.getByLabel('Unlocked for editing, click to lock.', { exact: true }).click();
// get the initial tab index
const initialTab = page.getByLabel(/- selected/);
// switch to a different tab in the view
Expand All @@ -113,7 +113,7 @@ test.describe('Tabs View', () => {
await expect(lockedSelectedTab).toHaveText(await initialTab.textContent());

//unlock the view
await page.getByLabel('Locked for editing - click to unlock.', { exact: true }).click();
await page.getByLabel('Locked for editing. Click to unlock.', { exact: true }).click();
// switch to a different tab in the view
await swgTab.click();
await page.getByLabel(`${sineWaveGenerator.name} Object View`).isVisible();
Expand Down
Loading