Make stack trace more readable (ARCANEDEV#141)

* Make stack trace more readable

  * Make only stack row scrollable if it doesn't fit in the window size
  * Make trace's font lighter
  * Add ability to highlight words in trace. Make it configurable with line numbers by default

* Update code due to PR comments

* Fix scroll on hidden stack rows in windows

config/log-viewer.php

@@ -113,4 +113,13 @@
             'debug'     => '#90CAF9',
         ],
     ],
+
+    /* ------------------------------------------------------------------------------------------------
+     |  Strings to highlight in stack trace
+     | ------------------------------------------------------------------------------------------------
+     */
+    'highlight' => [
+      '^#\d+',
+      '^Stack trace:',
+    ],
 ];

resources/views/_template/style.blade.php

@@ -83,15 +83,23 @@
     .table-condensed > thead > tr > td.stack {
         padding: 0;
         border-top: none;
+        background-color: #F6F6F6;
+        border-top: 1px solid #D1D1D1;
+        max-width: 0;
+        overflow-x: auto;
+    }
+
+    .table-condensed > tbody > tr > td > p {
+      margin: 0;
     }
 
     .stack-content {
         padding: 8px;
-        background-color: #F6F6F6;
-        border-top: 1px solid #D1D1D1;
         color: #AE0E0E;
-        font-family: consolas,sans-serif;
+        font-family: consolas, Menlo, Courier, monospace;
         font-size: 12px;
+        font-weight: 400;
+        white-space: pre-line;
     }
 
     .info-box.level {

resources/views/show.blade.php

@@ -193,6 +193,16 @@
 
                 return false;
             });
+
+            @unless (empty(log_styler()->toHighlight()))
+            $('.stack-content').each(function() {
+                var $this = $(this);
+                var html = $this.html().trim()
+                    .replace(/({!! join(log_styler()->toHighlight(), '|') !!})/gm, '<strong>$1</strong>');
+
+                $this.html(html);
+            });
+            @endunless
         });
     </script>
 @endsection

src/Contracts/Utilities/LogStyler.php

@@ -31,4 +31,13 @@ public function icon($level, $default = null);
      * @return string
      */
     public function color($level, $default = null);
+
+    /**
+     * Get strings to highlight.
+     *
+     * @param  array  $default
+     *
+     * @return string
+     */
+    public function toHighlight(array $default = []);
 }

src/Entities/LogEntry.php

@@ -170,7 +170,7 @@ public function icon()
      */
     public function stack()
     {
-        return nl2br(htmlentities($this->stack), false);
+        return trim(htmlentities($this->stack));
     }
 
     /* ------------------------------------------------------------------------------------------------

src/Utilities/LogStyler.php

@@ -82,4 +82,16 @@ public function color($level, $default = null)
     {
         return $this->get("colors.levels.$level", $default);
     }
+
+    /**
+     * Get strings to highlight.
+     *
+     * @param  array  $default
+     *
+     * @return string
+     */
+    public function toHighlight(array $default = [])
+    {
+        return $this->get("highlight", $default);
+    }
 }

tests/Utilities/LogStylerTest.php

@@ -101,4 +101,15 @@ public function it_can_use_helper_get_color()
             $this->assertHexColor(log_styler()->color($level));
         }
     }
+
+    /** @test */
+    public function it_can_get_string_to_highlight()
+    {
+        $expected = [
+            '^#\d+',
+            '^Stack trace:',
+        ];
+
+        $this->assertSame($expected, $this->styler->toHighlight());
+    }
 }