Adding Laravel 5.7 Support

neoteknic · Sep 4, 2018 · 1e12bb8 · 1e12bb8
1 parent fd12673
commit 1e12bb8
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 24 deletions.
diff --git a/composer.json b/composer.json
@@ -16,10 +16,11 @@
     "require": {
         "php":               ">=7.1.3",
         "psr/log":           "~1.0",
-        "arcanedev/support": "~4.3.0"
+        "arcanedev/support": "~4.4.0"
     },
     "require-dev": {
-        "orchestra/testbench": "~3.6.0",
+        "orchestra/testbench": "~3.7.0",
+        "mockery/mockery":     "~1.0",
         "phpunit/phpunit":     "~7.0",
         "phpunit/phpcov":      "~5.0"
     },

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -9,7 +9,6 @@
          convertWarningsToExceptions="true"
          processIsolation="false"
          stopOnFailure="false"
-         syntaxCheck="true"
          verbose="true">
     <testsuites>
         <testsuite name="Package Test Suite">
@@ -27,6 +26,6 @@
     <logging>
         <log type="coverage-clover" target="build/logs/clover.xml"/>
         <log type="coverage-text" target="build/logs/coverage.txt"/>
-        <log type="coverage-html" target="build/logs/coverage" charset="UTF-8" yui="true" highlight="true"/>
+        <log type="coverage-html" target="build/logs/coverage"/>
     </logging>
 </phpunit>
diff --git a/tests/Commands/CheckCommandTest.php b/tests/Commands/CheckCommandTest.php
@@ -18,8 +18,7 @@ class CheckCommandTest extends TestCase
     /** @test */
     public function it_can_check()
     {
-        $code = $this->artisan('log-viewer:check');
-
-        static::assertSame(0, $code);
+        $this->artisan('log-viewer:check')
+             ->assertExitCode(0);
     }
 }
diff --git a/tests/Commands/PublishCommandTest.php b/tests/Commands/PublishCommandTest.php
@@ -38,9 +38,9 @@ protected function tearDown()
     /** @test */
     public function it_can_publish_all()
     {
-        $code = $this->artisan('log-viewer:publish');
+        $this->artisan('log-viewer:publish')
+             ->assertExitCode(0);
 
-        static::assertSame(0, $code);
         static::assertHasConfigFile();
         static::assertHasLocalizationFiles();
         // TODO: Add views assertions
@@ -49,11 +49,9 @@ public function it_can_publish_all()
     /** @test */
     public function it_can_publish_all_with_force()
     {
-        $code = $this->artisan('log-viewer:publish', [
-            '--force'   => true
-        ]);
+        $this->artisan('log-viewer:publish', ['--force'   => true])
+             ->assertExitCode(0);
 
-        static::assertEquals(0, $code);
         static::assertHasConfigFile();
         static::assertHasLocalizationFiles();
         // TODO: Add views assertions
@@ -62,11 +60,9 @@ public function it_can_publish_all_with_force()
     /** @test */
     public function it_can_publish_only_config()
     {
-        $code = $this->artisan('log-viewer:publish', [
-            '--tag' => 'config'
-        ]);
+        $this->artisan('log-viewer:publish', ['--tag' => 'config'])
+             ->assertExitCode(0);
 
-        static::assertSame(0, $code);
         static::assertHasConfigFile();
         static::assertHasNotLocalizationFiles();
         // TODO: Add views assertions
@@ -75,11 +71,9 @@ public function it_can_publish_only_config()
     /** @test */
     public function it_can_publish_only_translations()
     {
-        $code = $this->artisan('log-viewer:publish', [
-            '--tag' => 'lang'
-        ]);
+        $this->artisan('log-viewer:publish', ['--tag' => 'lang'])
+             ->assertExitCode(0);
 
-        static::assertSame(0, $code);
         static::assertHasNotConfigFile();
         static::assertHasLocalizationFiles();
         // TODO: Add views assertions

diff --git a/tests/Commands/StatsCommandTest.php b/tests/Commands/StatsCommandTest.php
@@ -18,8 +18,7 @@ class StatsCommandTest extends TestCase
     /** @test */
     public function it_can_display_stats()
     {
-        $code = $this->artisan('log-viewer:stats');
-
-        static::assertSame(0, $code);
+        $this->artisan('log-viewer:stats')
+             ->assertExitCode(0);
     }
 }