Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deep copy dist func params into AlgorithmInterface #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

deep copy dist func params into AlgorithmInterface #168

wants to merge 1 commit into from
+29 −28

Conversation

renewboy
Copy link

No description provided.

@renewboy renewboy mentioned this pull request Nov 16, 2019
Open
@yurymalkov
Copy link
Member

Hi @zouyxdut,

Thank you!

I've checked the commit and it turns out it causes noticeable performance degradation (~7-8%).
This seems to be caused by the overhead of constant .get(). This probably by calling it once inside the constructor and using a (void *) copy, while still solving the problem with lifetime.

Can you please also redo the PR against the develop branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renewboy @yurymalkov