Update removePoint in bruteforce.h #382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bongmo
commented
Jun 7, 2022
- When I add some points and delete all points, unordered_map remains item (bug)
Add information about the patent
- bruteforce.h : removePoint bug fix
yurymalkov
reviewed
Jun 13, 2022
| @@ -78,7 +78,8 @@ namespace hnswlib { | |||
| dict_external_to_internal.erase(cur_external); | |||
|
|
|||
| labeltype label=*((labeltype*)(data_ + size_per_element_ * (cur_element_count-1) + data_size_)); | |||
| dict_external_to_internal[label]=cur_c; | |||
| if (cur_external != label) | |||
There was a problem hiding this comment.
I guess a check for cur_element_count>1 would be easier to read.
Also I think copying of the element in the next lines do not make any sense so should be in the same if
|
@bongmo thanks for the PR! That does seem like a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.