Skip to content

jenkins: use /bin/sh syntax in select-compiler.sh - #1994

Merged
sam-github merged 1 commit into
nodejs:masterfrom
sam-github:use-sh-in-select-compiler
Oct 23, 2019
Merged

sam-github merged 1 commit into
nodejs:masterfrom
sam-github:use-sh-in-select-compiler

Conversation

@sam-github

Copy link
Copy Markdown
Contributor

Fixes: #1992

@sam-github

Copy link
Copy Markdown
Contributor Author

I reproduced the original syntax error with /bin/dash on Linux, and this fixes it (and uses the same case syntax as the rest of the file). I'm in process of trying to repro and proves this fixes it on actual AIX.

@sam-github

Copy link
Copy Markdown
Contributor Author

I verified that the original could not be sourced on AIX, and that this can be after conversion to case statements.

@nodejs/build can I fasttrack this onto master?

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it works

@mhdawson

Copy link
Copy Markdown
Member

+1 to fasttrack since I think AIX Is currently broken.

@sam-github
sam-github merged commit 0380dad into nodejs:master Oct 23, 2019
@sam-github
sam-github deleted the use-sh-in-select-compiler branch October 23, 2019 15:38
@sam-github

Copy link
Copy Markdown
Contributor Author

https://ci.nodejs.org/job/node-test-commit/32083/

^-- kicked off a test run on master to confirm nothing was broken by this

@richardlau

Copy link
Copy Markdown
Member

Belated LGTM.

richardlau added a commit that referenced this pull request Nov 12, 2019
Fix the `select-compiler.sh` script for `node-test-commit-v8-linux ` which runs on
`benchmark-ubuntu1604-intel-64`.

Refs: #1985
Refs: #1994
richardlau added a commit that referenced this pull request Nov 13, 2019
Fix the `select-compiler.sh` script for `node-test-commit-v8-linux ` which runs on
`benchmark-ubuntu1604-intel-64`.

Refs: #1985
Refs: #1994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select compiler broken on AIX

3 participants