Repository navigation
jenkins: use /bin/sh syntax in select-compiler.sh - #1994
Merged
Merged
Conversation
Contributor
Author
|
I reproduced the original syntax error with /bin/dash on Linux, and this fixes it (and uses the same case syntax as the rest of the file). I'm in process of trying to repro and proves this fixes it on actual AIX. |
Contributor
Author
|
I verified that the original could not be sourced on AIX, and that this can be after conversion to case statements. @nodejs/build can I fasttrack this onto master? |
Member
|
+1 to fasttrack since I think AIX Is currently broken. |
Contributor
Author
|
^-- kicked off a test run on master to confirm nothing was broken by this |
Member
|
Belated LGTM. |
This was referenced Nov 12, 2019
richardlau
added a commit
that referenced
this pull request
Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1992