Repository navigation
Conversation
|
@addaleax |
addaleax
left a comment
There was a problem hiding this comment.
LGTM with the small nit that current style here (and, afaik, in all our Python files) is lambda a: without an extra space
refack
left a comment
There was a problem hiding this comment.
LGTM.
Preferably with nit fixed, but non-blocking.
|
/CC @nodejs/python @nodejs/build-files |
|
P.S. this might be semver-major since it changes the content of our "SDK" (the headers tarball) |
|
Thanks for review! I addressed comments and started CI: https://ci.nodejs.org/job/node-test-pull-request/16879/ |
These headers are exposed from V8 for embedder and should not be used by native addons. Fixes #22415
|
Landed in 4b47d29 |
These headers are exposed from V8 for embedder and should not be
used by native addons.
Fixes #22415
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes