[addaleax]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

@addaleax sadly an error occured when I tried to trigger a build :(

[addaleax]

@hashseed Does this mean that https://bugs.chromium.org/p/v8/issues/detail?id=8465 has been resolved?

CI: https://ci.nodejs.org/job/node-test-pull-request/20088/

[addaleax]

(I’m noticing that it probably hasn’t been resolved, because adding while(true); at the end of the loop() function still makes the test hang?)

[hashseed]

I haven't had time to take a look there yet. I think it has already been fixed, but there may be some cases where things are still not working correctly.

[addaleax]

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20227/

[addaleax]

Resume CI again: https://ci.nodejs.org/job/node-test-pull-request/20241/

[addaleax]

The Windows results look like infra failures, so I’m a bit confused…

Full New CI: https://ci.nodejs.org/job/node-test-pull-request/20245/ (✔️ )

[richardlau]

The Windows results look like infra failures, so I’m a bit confused…

FYI, binaries are currently deleted after 7 days (nodejs/build#1515 (comment)) so you have that long to resume a build, after which you will need to kick off a brand new CI.

[danbev]

Landed in 2c9e12e.