Repository navigation
stream: improve read() performance - #29337
Merged
Merged
Conversation
Fishrock123
reviewed
Aug 28, 2019
Fishrock123
left a comment
Contributor
There was a problem hiding this comment.
This code is frankly quite difficult to understand, but I think this is correct.
jasnell
approved these changes
Aug 28, 2019
Member
|
@nodejs/streams |
mcollina
approved these changes
Aug 29, 2019
mcollina
left a comment
Member
There was a problem hiding this comment.
LGTM, good work! A CITGM run would be helpful to assess any breakage.
Contributor
Author
|
@mcollina What breakage? These changes consist of:
|
Member
|
I'm skeptical of any side effect a change in streams can have at this point, so a run would not be a waste of time. |
Member
|
I don't see anything suspicious on CITGM, LGTM from me. |
devnexen
approved these changes
Aug 30, 2019
PR-URL: nodejs#29337 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
mscdex
force-pushed
the
stream-read-perf
branch
from
August 31, 2019 03:40
172edd9 to
98b7185
Compare
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
PR-URL: #29337 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
PR-URL: #29337 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark results:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes