Skip to content

test: use relative paths within test directory in test-watch-mode.mjs - #67343

Open
LiviaMedeiros wants to merge 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-watch-mode-avoid-tmp
Open

LiviaMedeiros wants to merge 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-watch-mode-avoid-tmp

Conversation

@LiviaMedeiros

Copy link
Copy Markdown
Member

This test pollutes os.tmpdir() with directories that are never removed. Let's try relative paths within tmpdir.path instead.
If this won't work, we can use mkdtempDisposable().

rm -rf /tmp/test\ for\ --watch\ parsing/ /tmp/node-watch-path-a/ /tmp/node-watch-path-b/ for manual cleanup.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 8, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Signed-off-by: LiviaMedeiros <livia@cirno.name>
@LiviaMedeiros
LiviaMedeiros force-pushed the test-watch-mode-avoid-tmp branch from d15bddd to 09530e1 Compare November 14, 2026 01:50
@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.71%. Comparing base (dadf029) to head (09530e1).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #67343   +/-   ##
=======================================
  Coverage   90.70%   90.71%           
=======================================
  Files         802      802           
  Lines      282114   282114           
  Branches    54360    54359    -1     
=======================================
+ Hits       255892   255913   +21     
+ Misses      16363    16327   -36     
- Partials     9859     9874   +15     

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros LiviaMedeiros added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 14, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 14, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - test: use relative paths within test directory in `test-watch-mode.mjs`

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
�[36m⠋�[39m Loading data for nodejs/node/pull/67343
�[36m⠋�[39m Loading data for nodejs/node/pull/67343
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/67343
�[36m⠋�[39m Getting reviews from nodejs/node/pull/67343
�[36m⠋�[39m Getting comments from nodejs/node/pull/67343
�[36m⠋�[39m Getting commits from nodejs/node/pull/67343
✔  Done loading data for nodejs/node/pull/67343
----------------------------------- PR info ------------------------------------
Title      test: use relative paths within test directory in `test-watch-mode.mjs` (#67343)
Author     Livia Medeiros <livia@cirno.name> (@LiviaMedeiros)
Branch     LiviaMedeiros:test-watch-mode-avoid-tmp -> nodejs:main
Labels     test, author ready, needs-ci, commit-queue
Commits    1
 - test: use relative paths within test directory in `test-watch-mode.mjs`
Committers 1
 - LiviaMedeiros <livia@cirno.name>
PR-URL: https://github.com/nodejs/node/pull/67343
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/67343
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 08 Nov 2026 10:27:35 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/67343#pullrequestreview-5833070485
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/67343#pullrequestreview-5901987319
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-11-08T17:54:11Z: https://ci.nodejs.org/job/node-test-pull-request/78910/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - test: use relative paths within test directory in `test-watch-mode.mjs`
�[36m⠙�[39m Querying data for job/node-test-pull-request/78910/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78910/
�[36m⠙�[39m Querying API for job/node-test-pull-request/78910/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
�[36m⠹�[39m Querying API for job/node-test-pull-request/78910/
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants