Fix struct newtype deserialization (and add tests)#45
Merged
bors[bot] merged 2 commits intonox:masterfrom Nov 19, 2018
Merged
Conversation
Owner
|
Nice. Could you bump the version to 0.5.4 while at it? |
Contributor
Author
|
Sure - version bumped |
Owner
|
bors r+ Feel free to ping me if I forget to publish the new version once this lands. |
bors bot
added a commit
that referenced
this pull request
Nov 19, 2018
45: Fix struct newtype deserialization (and add tests) r=nox a=samsieber Fixes #41 I only had to fix the deserializer - the serialization already works. So now they work the same way - you can serialize something and then deserialize it losslessly. I also added tests for serialization and deserialization. Let me know if there's anything you'd like changed. Co-authored-by: Sam Sieber <swsieber@gmail.com>
Contributor
Build succeeded |
Contributor
Author
|
@nox ping! I actually have no idea how long it takes for you to cut a release, so I'll ping you again in a day or two if I don't see it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41
I only had to fix the deserializer - the serialization already works. So now they work the same way - you can serialize something and then deserialize it losslessly.
I also added tests for serialization and deserialization. Let me know if there's anything you'd like changed.