fix(core): add option to use v8 for daemon message serialization to avoid issues when JSON.stringify would fail #30516

AgentEnder · 2025-03-26T22:33:32Z

Current Behavior

For really large objects (particularly those containing large strings) JSON.stringify can fail

Expected Behavior

Daemon serialization doesn't fail for the same strings when setting NX_USE_V8_SERIALIZER=true. This should become the default behavior.

Related Issue(s)

Fixes #

vercel · 2025-03-26T22:33:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	Jun 30, 2025 8:27pm

nx-cloud · 2025-03-26T22:34:23Z

View your CI Pipeline Execution ↗ for commit 7a66080.

Command	Status	Duration	Result
`nx affected --targets=lint,test,build,e2e,e2e-c...`	✅ Succeeded	42m 17s	View ↗
`nx run-many -t check-imports check-commit check...`	✅ Succeeded	16s	View ↗
`nx-cloud record -- nx-cloud conformance:check`	✅ Succeeded	2s	View ↗
`nx-cloud record -- nx format:check`	✅ Succeeded	6s	View ↗
`nx-cloud record -- nx sync:check`	✅ Succeeded	4s	View ↗
`nx documentation`	✅ Succeeded	2m 36s	View ↗

☁️ Nx Cloud last updated this comment at 2025-06-30 20:51:22 UTC

github-actions · 2025-04-09T21:28:01Z

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-30516-4c8bfff

Release details	📑
Published version	0.0.0-pr-30516-4c8bfff
Triggered by	@AgentEnder
Branch	fix/core/v8-serialize
Commit	4c8bfff
Workflow run	14366949600

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

github-actions · 2025-04-15T15:20:49Z

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-30516-94d09ba

Release details	📑
Published version	0.0.0-pr-30516-94d09ba
Triggered by	@AgentEnder
Branch	fix/core/v8-serialize
Commit	94d09ba
Workflow run	14472591662

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

packages/nx/src/utils/consume-messages-from-socket.ts

packages/nx/src/project-graph/plugins/isolation/plugin-pool.ts

packages/nx/src/command-line/daemon/daemon.ts

graphite-app · 2025-06-30T18:39:54Z

packages/nx/src/utils/consume-messages-from-socket.ts


      // Server may send multiple messages in one chunk, so splitting by 0x4
-      const messages = message.split('');
+      const messages = message.split(MESSAGE_END_SEQ);


There appears to be a logical issue with the message splitting implementation. The code first removes MESSAGE_END_SEQ from the end of the chunk, then attempts to split the resulting message by MESSAGE_END_SEQ. However, since the end sequence has already been removed, this split operation won't find any delimiters in the current message.

To properly handle multiple messages in one chunk, consider either:

Split the original chunk by MESSAGE_END_SEQ before removing the end sequence, or

Remove this split operation entirely if the design only expects one message per chunk after removing the end sequence

This could lead to missed messages if multiple complete messages arrive in a single chunk.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

packages/nx/src/utils/consume-messages-from-socket.ts

graphite-app · 2025-06-30T18:46:07Z

packages/nx/src/utils/consume-messages-from-socket.ts

+    // strings
+    (message.startsWith('"') && message.endsWith('"')) ||
+    // numbers
+/^[0-9]+(\\.?[0-9]+)?$/.test(message)


The regex pattern for matching numbers has an issue with the escaped decimal point. The current pattern /^[0-9]+(\.?[0-9]+)?$/ makes both the decimal point and the digits after it optional, which would incorrectly match strings like "123." (ending with a dot).

A more accurate pattern would be /^[0-9]+(\.[0-9]+)?$/ where only the entire decimal portion (dot + digits) is optional, ensuring that if a decimal point is present, it must be followed by at least one digit.

Suggested change

/^[0-9]+(\\.?[0-9]+)?$/.test(message)

/^[0-9]+(\\.?[0-9]+)?$/.test(message)

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

…void issues when JSON.stringify would fail fix(core): v8 serializer should be able to hash tasks feat(core): use v8 serializer for daemon messages by default

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

graphite-app · 2025-06-30T19:57:52Z

packages/nx/src/project-graph/plugins/isolation/plugin-pool.ts

+      `No pending promise found for transaction "${tx}". This may indicate a bug in the plugin pool. Currently pending promises:\n` +
+        Object.keys(pending).map((t) => `  -  ${t}`).join('\n')


There's an issue with the error message construction. Since pending is a Map, using Object.keys(pending) won't work correctly. To properly display the keys from the Map, use Array.from(pending.keys()) instead:

`No pending promise found for transaction "${tx}". This may indicate a bug in the plugin pool. Currently pending promises:\n` + Array.from(pending.keys()).map((t) => ` - ${t}`).join('\n')

Suggested change

`No pending promise found for transaction "${tx}". This may indicate a bug in the plugin pool. Currently pending promises:\n` +

Object.keys(pending).map((t) => ` - ${t}`).join('\n')

`No pending promise found for transaction "${tx}". This may indicate a bug in the plugin pool. Currently pending promises:\n` +

Array.from(pending.keys()).map((t) => ` - ${t}`).join('\n')

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

…ion to avoid issues when JSON.stringify would fail (#30516)" This reverts commit a59e6eb.

#31881) …ion to avoid issues when JSON.stringify would fail (#30516)" This reverts commit a59e6eb.

…void issues when JSON.stringify would fail (#30516)      ## Current Behavior For really large objects (particularly those containing large strings) JSON.stringify can fail ## Expected Behavior Daemon serialization doesn't fail for the same strings when setting `NX_USE_V8_SERIALIZER=true`. This should become the default behavior. ## Related Issue(s)  Fixes # --------- Co-authored-by: Jason Jean <[email protected]> Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> (cherry picked from commit a59e6eb)

#31881) …ion to avoid issues when JSON.stringify would fail (#30516)" This reverts commit a59e6eb. (cherry picked from commit 3782d7e)

github-actions · 2025-07-15T00:11:56Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

AgentEnder force-pushed the fix/core/v8-serialize branch from 91f6d67 to 4c8bfff Compare March 27, 2025 13:36

AgentEnder marked this pull request as ready for review April 1, 2025 20:38

AgentEnder requested a review from a team as a code owner April 1, 2025 20:38

AgentEnder requested a review from Cammisuli April 1, 2025 20:38

AgentEnder force-pushed the fix/core/v8-serialize branch from 4c8bfff to 94d09ba Compare April 15, 2025 14:48

AgentEnder force-pushed the fix/core/v8-serialize branch from 9fc6183 to 3f73f1a Compare April 15, 2025 19:16

FrozenPandaz assigned AgentEnder Apr 25, 2025

AgentEnder force-pushed the fix/core/v8-serialize branch from 3f73f1a to ff3e197 Compare May 14, 2025 21:56

AgentEnder mentioned this pull request May 14, 2025

fix(core): use v8 serializer in v19 #31222

Closed

graphite-app bot reviewed May 24, 2025

View reviewed changes

packages/nx/src/utils/consume-messages-from-socket.ts Outdated Show resolved Hide resolved

packages/nx/src/project-graph/plugins/isolation/plugin-pool.ts Outdated Show resolved Hide resolved

FrozenPandaz added the priority: medium Medium Priority (not high, not low priority) label Jun 23, 2025

FrozenPandaz reviewed Jun 30, 2025

View reviewed changes

packages/nx/src/command-line/daemon/daemon.ts Outdated Show resolved Hide resolved

graphite-app bot reviewed Jun 30, 2025

View reviewed changes

FrozenPandaz approved these changes Jun 30, 2025

View reviewed changes

vercel bot deployed to Preview June 30, 2025 18:58 View deployment

AgentEnder and others added 5 commits June 30, 2025 15:54

fix(core): add option to use v8 for daemon message serialization to a…

25d4680

…void issues when JSON.stringify would fail fix(core): v8 serializer should be able to hash tasks feat(core): use v8 serializer for daemon messages by default

fix(core): fix regex

4fcbdc4

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

chore(core): remove unused import

a56175b

chore(core): fix error format

0bb5f41

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

chore(core): fix regex

0e1173a

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

AgentEnder force-pushed the fix/core/v8-serialize branch from ff075d9 to 0e1173a Compare June 30, 2025 19:56

graphite-app bot reviewed Jun 30, 2025

View reviewed changes

chore(core): apply code fix

7a66080

vercel bot deployed to Preview June 30, 2025 20:27 View deployment

FrozenPandaz approved these changes Jul 9, 2025

View reviewed changes

FrozenPandaz merged commit a59e6eb into master Jul 9, 2025
8 checks passed

FrozenPandaz deleted the fix/core/v8-serialize branch July 9, 2025 14:53

leosvelperez added a commit that referenced this pull request Jul 10, 2025

Revert "fix(core): add option to use v8 for daemon message serializat…

f70adce

…ion to avoid issues when JSON.stringify would fail (#30516)" This reverts commit a59e6eb.

leosvelperez mentioned this pull request Jul 10, 2025

Revert "fix(core): add option to use v8 for daemon message serializat… #31881

Merged

FrozenPandaz pushed a commit that referenced this pull request Jul 10, 2025

Revert "fix(core): add option to use v8 for daemon message serializat… (

3782d7e

#31881) …ion to avoid issues when JSON.stringify would fail (#30516)" This reverts commit a59e6eb.

github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(core): add option to use v8 for daemon message serialization to avoid issues when JSON.stringify would fail #30516

fix(core): add option to use v8 for daemon message serialization to avoid issues when JSON.stringify would fail #30516

Uh oh!

AgentEnder commented Mar 26, 2025 •

edited

Loading

Uh oh!

vercel bot commented Mar 26, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Mar 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app bot Jun 30, 2025

Uh oh!

Uh oh!

graphite-app bot Jun 30, 2025

Uh oh!

graphite-app bot Jun 30, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	/^[0-9]+(\\.?[0-9]+)?$/.test(message)
	/^[0-9]+(\\.?[0-9]+)?$/.test(message)

		`No pending promise found for transaction "${tx}". This may indicate a bug in the plugin pool. Currently pending promises:\n` +
		Object.keys(pending).map((t) => ` - ${t}`).join('\n')

fix(core): add option to use v8 for daemon message serialization to avoid issues when JSON.stringify would fail #30516

fix(core): add option to use v8 for daemon message serialization to avoid issues when JSON.stringify would fail #30516

Uh oh!

Conversation

AgentEnder commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Behavior

Expected Behavior

Related Issue(s)

Uh oh!

vercel bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2025

🐳 We have a release for that!

Uh oh!

github-actions bot commented Apr 15, 2025

🐳 We have a release for that!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app bot Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

graphite-app bot Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app bot Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AgentEnder commented Mar 26, 2025 •

edited

Loading

vercel bot commented Mar 26, 2025 •

edited

Loading

nx-cloud bot commented Mar 26, 2025 •

edited

Loading