(mini.completion) Update set_vim_settings's shortmess to hide completion messages#554
Merged
echasnovski merged 1 commit intonvim-mini:tmpfrom Nov 5, 2023
yamhab:completion-shortmess
Merged
(mini.completion) Update set_vim_settings's shortmess to hide completion messages#554echasnovski merged 1 commit intonvim-mini:tmpfrom yamhab:completion-shortmess
set_vim_settings's shortmess to hide completion messages#554echasnovski merged 1 commit intonvim-mini:tmpfrom
yamhab:completion-shortmess
Conversation
…pletion messages.
Member
|
Thanks for the PR! Yes, this makes sense. I've merged into a separate branch to polish a bit. Edit: This now should be part of the |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, mini.completion adds "c" to
shortmesswhenset_vim_settingsis enabled to reduce the amount of command line messages printed when completing. This PR also adds "C" toshortmessto further silence unnecessary messages. This has also already been referenced in #5 (comment) before. I've changed the code so that it detects to see if the user is using Neovim 0.9.0 or newer before adding the flag, and I also edited the appropriate tests.