Conversation
|
I like the notebook, but I’m tempted to make the README description more hand-wavy. I feel like either we explicit document the logic in pseudocode, or we just leave it vague like: “If a height is not specified, Plot will attempt to chose a reasonable default height based on the y and fy scale types and, for ordinal scales, the cardinality of the domain. The default height ranges from TK to TK, with 400 for the common case where y is quantitative and fy is not present.” |
|
We could publish the notebook and link to it for details. |
|
(Notebook further updated to take #837 into account.) |
|
18 months later, it's published :) https://observablehq.com/@observablehq/plot-default-height EDIT the URL above was redirected to the documentation, see new URL: https://observablehq.com/d/f7ce87cd798d9674 |
|
didn't mean to close the PR! |
|
closing, it seems ok to not document this more in depth |
see #337 and https://observablehq.com/@observablehq/plot-default-height
(cheat sheet #318)