prov/efa: Improve efa_cq's completion report #10771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Make efa_cq_construct_cq_entry correctly handle unsolicited wc where there is no valid wr_id 2. Make efa_cq_proc_ibv_recv_rdma_with_imm_completion reuse the constructed cq entry to remove the duplicated wc read. 3. Remove the eq error write for unsolicited write recv error, as it should be reported as a cq error with NULL op context (valid per libfabric man page). Signed-off-by: Shi Jin <[email protected]>
The current test_efa_cq* involves fi_send/fi_recv operations which are not relevant to the cq operation and make the test lose the value as unit tests. This patch rework the efa_cq unit tests to focus on the cq read operation and adds check for the returned cq entry. Signed-off-by: Shi Jin <[email protected]>
shijin-aws
commented
Feb 7, 2025
| entry->flags = efa_cq_opcode_to_fi_flags(ibv_wc_read_opcode(ibv_cqx)); | ||
| if (!efa_cq_wc_is_unsolicited(ibv_cqx) && ibv_cqx->wr_id) { | ||
| entry->op_context = (void *)ibv_cqx->wr_id; | ||
| entry->flags = (opcode == IBV_WC_RECV_RDMA_WITH_IMM) ? efa_cq_opcode_to_fi_flags(opcode): ((struct efa_context *) ibv_cqx->wr_id)->completion_flags; |
There was a problem hiding this comment.
This is needed when we support FI_RX_CQ_DATA, and doesn't hurt for current code
jiaxiyan
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is no valid wr_id
cq entry to remove the duplicated wc read.
be reported as a cq error with NULL op context (valid per libfabric man page).
Also did a rework of the efa_cq's unit tests