Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u8x8_draw_hvtile.c #1328

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

u8x8_draw_hvtile.c #1328

wants to merge 2 commits into from

Conversation

theeprawn
Copy link

This ones just hvtile changes to try make life easier. As said no worries if not use. But its adds consitency and shouldnt break anything, but will take abit more code space and RAM up. Display drivers that use horizontal architecture can updated as needed.
The tile buffer width is needed by the horizontal display drivers, otherwise there is no way of knowing width of sent buffer for incrementing a display row, because tile buffer width size sent to display driver changes. But generally it is 1byte wide for u8x8 and display row wide for u8g2.
I also added variable tile width to draw_hvtile conversion buffer, but as said its generally only 1 tile sent from u8x8 to display, but its there for consitency and maybe needed in future, adds very little to code size. The coversion method used not sure is best, but seems reasonably compact and not to processor or memory hungry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant