First untested version of Surenoo SSD1320 based 320x132x4 display for RP2040 and/or Zephyr (review) #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… RP2040 and/or Zephyr Display P/N: SOG320132A_M383 Surenoo Display datasheet: http://surenoo.tech/download/03_SOL/0302_SOG/SOG320132A_M383.pdf (a bit brief, but adequate) Surenoo SSD1320 datasheet: http://surenoo.tech/download/03_SOL/0302_SOG/Controller/SSD1320.pdf (includes command list) Two interfaces present: one for the Raspberry Pi RP2040 SDK, using e.g. gpio_set_function(), and one which I intended to be generic for Zephyr-RTOS, but which my lack of understanding is hampering. I think the pico-sdk versions are essentially ok, but the zephyr ones are not as yet. I have copied over the group of functions u8g2_m_40_17_2 et al and I think adjusted them properly, but I do not understand the choice of '17' here. Perhaps this area needs checking? I have also put #if 0 / #endif the *nhd_powersave1_seq arrays because they weren't used. I have no idea if they are correct for the 1320.
|
I need to refuse this PR. Most of the code (u8x8_m functions) is generated and the csrc folder should not contain target specific functions (gpio and delay). |
|
Created issue #1858, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display P/N: SOG320132A_M383
Surenoo Display datasheet: http://surenoo.tech/download/03_SOL/0302_SOG/SOG320132A_M383.pdf
(a bit brief, but adequate)
Surenoo SSD1320 datasheet: http://surenoo.tech/download/03_SOL/0302_SOG/Controller/SSD1320.pdf
(includes command list)
Two interfaces present: one for the Raspberry Pi RP2040 SDK, using e.g. gpio_set_function(),
and one which I intended to be generic for Zephyr-RTOS, but which my lack of understanding
is hampering. I think the pico-sdk versions are essentially ok, but the zephyr ones are not
as yet.
I have copied over the group of functions u8g2_m_40_17_2 et al and I think adjusted them
properly, but I do not understand the choice of '17' here. Perhaps this area needs checking?
I have also put #if 0 / #endif the *nhd_powersave1_seq arrays because they weren't used. I
have no idea if they are correct for the 1320.