sys: rt-thread: Check for U8X8_PIN_NONE. #2506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RT-Thread use signed value for its pin numbers, while using -1 for PIN_NONE. So when using U8X8_PIN_NONE, RT-Thread will incorrectly interpret the pin as positive integer (255).
This patch wraps rt_pin_xxx functions to detect this condition. It does limit the selectable pin ranges to 0-255, however it should be enough for now.