Conversation
Mainly includes a bump hyper to 1.x.
Since reqwest 0.12 http/2 support can be disabled to decrease binary size. And since range-requests and persistent connections are supported in http/1.1 it seems unnecessary for our use case to build with http/2 support. bita compiled (x86-64, in release mode+stripped) with http/2 support enabled adds ~900 KiB to the binary compared to a version without http/2 support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR bumps reqwest to 0.12, and with that hyper to 1.x.
PR also disables support for http/2. This since to my understanding http/2 does not provide any features needed for bita/bitar to fully function but adds a lot to the binary size.
bita compiled (x86-64, in release mode+stripped) with http/2 support enabled adds ~900 KiB to the binary compared to a version without http/2 support.