[network] topic validator for staked channels#1225
Merged
Conversation
Base automatically changed from
smnzhu/staked-sync-provider
to
smnzhu/identity-provider
August 30, 2021 16:06
cf0cf32 to
d937be0
Compare
huitseeker
reviewed
Aug 31, 2021
Contributor
huitseeker
left a comment
There was a problem hiding this comment.
Thanks a bunch! this looks good apart from a couple of places
9d8423a to
4ce2800
Compare
331c712 to
6b0fbcd
Compare
huitseeker
suggested changes
Sep 3, 2021
network/p2p/libp2pNode.go
Outdated
Comment on lines
+535
to
+540
| err := n.pubSub.UnregisterTopicValidator(topic.String()) | ||
| if err != nil { | ||
| return fmt.Errorf("could not unregister topic validator for (%s): %w", topic, err) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
as you'll see from CI, this fails if there's no validator on the topic (e.g. the subscribe call didn't keep any)
53dc28d to
ff800e9
Compare
… add topic validators for stake nodes
d16b62a to
596b11a
Compare
Contributor
Author
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Sep 7, 2021
1225: [network] topic validator for staked channels r=smnzhu a=smnzhu closes https://github.com/dapperlabs/flow-go/issues/5802 ### TODO: - [x] write tests Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com> Co-authored-by: François Garillot <francois.garillot@dapperlabs.com> Co-authored-by: Vishal <1117327+vishalchangrani@users.noreply.github.com>
Closed
Contributor
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
Member
|
bors cancel |
Contributor
|
Canceled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dapperlabs/flow-go/issues/5802
TODO: