Add WASM wheels build #1653
Draft
Add WASM wheels build #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's first test the build of the WASM wheels in an independant workflow so that it is easier to iterate and make sure it works before adding the logic to the pypi workflow.
e780d5f
to
e0fb7b5
Compare
e0fb7b5
to
c2b840e
Compare
|
Great stuff @gbolmier! For the pandas version, I guess it's fine to loosen it on our end. |
I would prefer too, if possible. @agriyakhetarpal do you remember why you bumped pandas from I just realized that Pyodide is not supporting NumPy @agriyakhetarpal does it mean that we need to wait for Pyodide to support newer pandas and NumPy versions in order to test River's WASM build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's first test the build of the WASM wheels in an independant workflow so that it is easier to iterate and make sure it works before adding the logic to the pypi workflow.
See #1649 thread for more context.
Current blocker is a conflict between River
pandas<3.0.0,>=2.2.3requirement and Pyodide pandas version (2.2.0) (see run error).