Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] runner's config is overwritten by resume() #1886

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SuTanTank
Copy link
Contributor

Motivation

Resolves #1875

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@HAOCHENYE
Copy link
Collaborator

Thanks for your contribution! It seems that the previous implementation has some bugs. But self.meta = checkpoint['meta'] still seems weird, the current exp_name and env_info will be overwritten, is this reasonable? Maybe @hhaAndroid could have a look.

@SuTanTank
Copy link
Contributor Author

SuTanTank commented Apr 26, 2022

I'm doing fp16 training recently and maybe I can fix the overwritten issue (introduced by #1013 ) in a more elegant way. No need to merge yet. @HAOCHENYE

Update: new commit pushed.

@SuTanTank
Copy link
Contributor Author

Any ideas about the CI failure?

@HAOCHENYE HAOCHENYE added the Ready label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resume() overwrites new config
3 participants