Skip to content

Conversation

@ianstanton
Copy link
Contributor

What this PR does / why we need it:
Add table with all available runtime flags for user / developer reference.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3358

Special notes for your reviewer:
@JaydipGabani Here is a first pass that we can iterate on in this PR or as a follow-up. I've added this for the latest version only. Let's discuss how we'd like to sort / categorize the flags, and let me know if I missed any 🙂

Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
@ianstanton ianstanton requested a review from a team as a code owner January 16, 2025 04:00
@stale
Copy link

stale bot commented Mar 18, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 18, 2025
@JaydipGabani
Copy link
Contributor

Not stale

@stale stale bot removed the stale label Mar 18, 2025
@JaydipGabani JaydipGabani added this to the v3.20.0 milestone Mar 19, 2025
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Please add recently added flag - enable-referential-rules here as well.

@ianstanton ianstanton requested a review from JaydipGabani May 15, 2025 23:28
@ianstanton ianstanton requested a review from JaydipGabani May 16, 2025 00:20
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just make sure to match these flags to 3.18 version and it should be good to merge.

Thanks!

@JaydipGabani
Copy link
Contributor

@ianstanton any update on this^^

@ianstanton
Copy link
Contributor Author

@ianstanton any update on this^^

I should be able to get to this in the evening. Thanks for your patience!

@ianstanton ianstanton requested a review from JaydipGabani May 28, 2025 11:57
@ianstanton
Copy link
Contributor Author

@JaydipGabani This is ready for another pass, so let me know if we need any additional changes.

Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ritazh @sozercan PTAL

| `--audit-connection` | `"audit-connection"` | (alpha) Connection name for exporting audit violation messages. Defaults to audit-connection. |
| `--audit-channel` | `"audit-channel"` | (alpha) Channel name for exporting audit violation messages. Defaults to audit-channel. |
| `--log-stats-audit` | `false` | (alpha) Log stats metrics for the audit run. |
| `--default-create-vap-binding-for-constraints` | `false` | (alpha) Create VAPBinding resource for constraint of the template containing VAP-style CEL source. Allowed values are false: do not create Validating Admission Policy Binding, true: create Validating Admission Policy Binding. |
Copy link
Member

@sozercan sozercan Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beta now, right @JaydipGabani? same for other vap flags

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yip.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after vap correction. this is a great start, and for next steps, we should think about automating this to avoid staleness.

Signed-off-by: Jaydip Gabani <[email protected]>
@sozercan sozercan merged commit 5044756 into open-policy-agent:master Jun 11, 2025
5 checks passed
grelland pushed a commit to grelland/gatekeeper that referenced this pull request Jun 12, 2025
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
Co-authored-by: Jaydip Gabani <[email protected]>
sozercan pushed a commit to sozercan/gatekeeper that referenced this pull request Jun 18, 2025
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
Co-authored-by: Jaydip Gabani <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: Add a page to include all flag information in one place

3 participants