-
Notifications
You must be signed in to change notification settings - Fork 846
docs: Add Flags Reference #3782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
|
Not stale |
JaydipGabani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Please add recently added flag - enable-referential-rules here as well.
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
JaydipGabani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just make sure to match these flags to 3.18 version and it should be good to merge.
Thanks!
|
@ianstanton any update on this^^ |
I should be able to get to this in the evening. Thanks for your patience! |
Signed-off-by: Ian Stanton <[email protected]>
|
@JaydipGabani This is ready for another pass, so let me know if we need any additional changes. |
JaydipGabani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
website/docs/runtime-flags.md
Outdated
| | `--audit-connection` | `"audit-connection"` | (alpha) Connection name for exporting audit violation messages. Defaults to audit-connection. | | ||
| | `--audit-channel` | `"audit-channel"` | (alpha) Channel name for exporting audit violation messages. Defaults to audit-channel. | | ||
| | `--log-stats-audit` | `false` | (alpha) Log stats metrics for the audit run. | | ||
| | `--default-create-vap-binding-for-constraints` | `false` | (alpha) Create VAPBinding resource for constraint of the template containing VAP-style CEL source. Allowed values are false: do not create Validating Admission Policy Binding, true: create Validating Admission Policy Binding. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beta now, right @JaydipGabani? same for other vap flags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yip.
sozercan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after vap correction. this is a great start, and for next steps, we should think about automating this to avoid staleness.
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Ian Stanton <[email protected]> Signed-off-by: Jaydip Gabani <[email protected]> Co-authored-by: Jaydip Gabani <[email protected]>
Signed-off-by: Ian Stanton <[email protected]> Signed-off-by: Jaydip Gabani <[email protected]> Co-authored-by: Jaydip Gabani <[email protected]> Signed-off-by: Sertac Ozercan <[email protected]>
What this PR does / why we need it:
Add table with all available runtime flags for user / developer reference.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3358
Special notes for your reviewer:
@JaydipGabani Here is a first pass that we can iterate on in this PR or as a follow-up. I've added this for the latest version only. Let's discuss how we'd like to sort / categorize the flags, and let me know if I missed any 🙂