-
Notifications
You must be signed in to change notification settings - Fork 846
fix: disk export path to handle dir deletes #4021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disk export path to handle dir deletes #4021
Conversation
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4021 +/- ##
===========================================
- Coverage 54.49% 39.12% -15.38%
===========================================
Files 134 243 +109
Lines 12329 20515 +8186
===========================================
+ Hits 6719 8027 +1308
- Misses 5116 11906 +6790
- Partials 494 582 +88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
JaydipGabani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR does / why we need it:
The parent directory needs to be writeable for removing child dirs, so when we mount the writable empty dir, do so at the
tmp/violations, but in the connection path use a child directory ie /tmp/violations/topics
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #4012
Special notes for your reviewer: