Skip to content

Conversation

@nreisch
Copy link
Contributor

@nreisch nreisch commented Jun 24, 2025

What this PR does / why we need it:
The parent directory needs to be writeable for removing child dirs, so when we mount the writable empty dir, do so at the
tmp/violations, but in the connection path use a child directory ie /tmp/violations/topics

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #4012

Special notes for your reviewer:

nreisch added 13 commits June 13, 2025 14:30
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
Signed-off-by: Noah Reisch <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.12%. Comparing base (3350319) to head (78e14ab).
Report is 393 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (78e14ab). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (78e14ab)
unittests 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4021       +/-   ##
===========================================
- Coverage   54.49%   39.12%   -15.38%     
===========================================
  Files         134      243      +109     
  Lines       12329    20515     +8186     
===========================================
+ Hits         6719     8027     +1308     
- Misses       5116    11906     +6790     
- Partials      494      582       +88     
Flag Coverage Δ
unittests 39.12% <ø> (-15.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nreisch nreisch marked this pull request as ready for review June 27, 2025 16:19
@nreisch nreisch requested a review from a team as a code owner June 27, 2025 16:19
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JaydipGabani JaydipGabani merged commit a696953 into open-policy-agent:master Jul 1, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error "unlinkat /tmp/violations: read-only file system" in Disk driver CloseConnection

4 participants