Update otelcol to use the new client package API #6244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2021
|
Please update the PR. |
Fixes open-telemetry/opentelemetry-collector/issues/4420 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
6e7691f
to
d8d9ea1
Compare
|
Status: I'm still working on fixing other components making use of the removed API. |
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
|
I believe this is now ready for review. |
bogdandrutu
approved these changes
Nov 18, 2021
jpkrohling
referenced
this pull request
in jpkrohling/opentelemetry-collector-contrib
Nov 23, 2021
Requires #6244 Fixes open-telemetry/opentelemetry-collector#4421 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
added a commit
that referenced
this pull request
Nov 23, 2021
* Update otel to latest Signed-off-by: Juraci Paixão Kröhling <[email protected]> * Change OIDC authenticator to use AuthData Requires #6244 Fixes open-telemetry/opentelemetry-collector#4421 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
Remove custom rendering for slice and map values and use Value.AsString() instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-collector/issues/4420 by removing the explicit usage of client.Client in favor of the underlying helpers (confighttp/configgrpc), or by using the new client.Info, as it's the case for the k8sprocessor. The second commit also updates to the latest OpenTelemetry Collector, which includes the changes to the client package.
Fixes #6370 by changing the redisreceiver to use the new API, as required by the update to the latest OpenTelemetry Collector. The two fixes are part of the same PR, otherwise, contrib would be in a broken state after an update to otelcol.
I recommend reviewing this PR filtering only the "*.go" files. The go.mod/go.sum are automatic changes, made via
make update-otel.Signed-off-by: Juraci Paixão Kröhling [email protected]