Fail when the builder can't load its configuration.

If the builder can't load its build configuration file, it logs an error and continues. This results in building a collector that is not the one the user specified. Exit with a fatal error instead. Signed-off-by: James Peach <[email protected]>
open-telemetry · Jul 22, 2022 · d9b5b02 · d9b5b02
1 parent 61c6989
commit d9b5b02
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,6 +20,7 @@
 - Expose `pcommon.NewSliceFromRaw` function (#5679)
 - `loggingexporter`: create the exporter's logger from the service's logger (#5677)
 - Add `otelcol_exporter_queue_capacity` metrics show the collector's exporter queue capacity (#5475)
+- `ocb` now exits with an error if it fails to load the build configuration. (#5731)
 
 ### 🧰 Bug fixes 🧰
 

diff --git a/cmd/builder/internal/command.go b/cmd/builder/internal/command.go
@@ -90,7 +90,7 @@ func initConfig() error {
 
 	// load the config file
 	if err := k.Load(file.Provider(cfgFile), yaml.Parser()); err != nil {
-		cfg.Logger.Error("failed to load config file", zap.String("config-file", cfgFile), zap.Error(err))
+		cfg.Logger.Fatal("failed to load config file", zap.String("config-file", cfgFile), zap.Error(err))
 	}
 
 	// handle env variables