You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Collector currently does retries for HTTP error codes 414 and 431. This is not necessary since 431 is the HTTP error code for 'Request Header Fields Too Large' and 414 is the HTTP error code for 'URI Too Long'
These error code should be treated as permanent error in the Collector so that they won't get retried.
Describe the solution you'd like
Currently Collector only treats 400 as permanent error.
if resp.StatusCode == http.StatusBadRequest {
// Report the failure as permanent if the server thinks the request is malformed.
return consumererror.NewPermanent(formattedErr)
}
The solution is to add 431 and 414 to the permanent error list.
Describe alternatives you've considered
Currently we have an interceptor to handle this.
The text was updated successfully, but these errors were encountered:
@jpkrohling@rahuldimri please see the PR #5685.
@mcmho can you please see if you can pick up the 431 as well. I think it is better to have a set defined explicitly and loop through the list.
Is your feature request related to a problem? Please describe.
Collector currently does retries for HTTP error codes 414 and 431. This is not necessary since 431 is the HTTP error code for 'Request Header Fields Too Large' and 414 is the HTTP error code for 'URI Too Long'
These error code should be treated as permanent error in the Collector so that they won't get retried.
Describe the solution you'd like
Currently Collector only treats 400 as permanent error.
The solution is to add 431 and 414 to the permanent error list.
Describe alternatives you've considered
Currently we have an interceptor to handle this.
The text was updated successfully, but these errors were encountered: