[otlphttpreceiver] Allow H2C connections to otlp http receiver#10996
[otlphttpreceiver] Allow H2C connections to otlp http receiver#10996iblancasa wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10996 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 455 455
Lines 24038 24044 +6
=======================================
+ Hits 22037 22043 +6
Misses 1629 1629
Partials 372 372 ☔ View full report in Codecov by Sentry. |
|
@djaglowski could you take a look? |
jpkrohling
left a comment
There was a problem hiding this comment.
I believe this should be opt-in, and have a log warning stating that this is a "weird" configuration. Only very specific setups have a valid reason to have this enabled, such as sidecars terminating TLS right before handing over to the main container.
|
Is there anything else pending from this PR? |
|
Can somebody from @open-telemetry/collector-approvers take a look? Thank you |
jpkrohling
left a comment
There was a problem hiding this comment.
LGTM, however, I feel bad for introducing new features when we are aiming for v1.
If the Collector approvers decide that this is something we should NOT have for v1, I'd be on their side.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
|
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Heya! Curious if there was there any further alignment with the Collector team on landing this prior to getting it auto-closed. Thanks! |
I closed the PR since it seems there was not real interest on the feature. |
Description
Allow H2C connections to otlp http receiver
Fixes #10952