Skip to content
Sign in to GitHub · GitHub
Skip to content

Sign in to GitHub

Forgot password?

Password login alternatives

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/stackdriver: stackdriver support #139

Closed
wants to merge 1 commit into from
Closed

exporter/stackdriver: stackdriver support #139

wants to merge 1 commit into from

Conversation

inigohu
Copy link
Contributor

@inigohu inigohu commented Jul 8, 2019

migrate opencensus stackdriver exporter to opentelemetry

  • add factory
  • add config

migrate opencensus stackdriver exporter to opentelemetry
- add factory
- add config
@codecov-io
Copy link

Codecov Report

Merging #139 into master will decrease coverage by 0.71%.
The diff coverage is 2.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   69.78%   69.06%   -0.72%     
==========================================
  Files         101      103       +2     
  Lines        6391     6466      +75     
==========================================
+ Hits         4460     4466       +6     
- Misses       1696     1766      +70     
+ Partials      235      234       -1
Impacted Files Coverage Δ
exporter/stackdriverexporter/stackdriver.go 0% <0%> (ø)
internal/config/config.go 20.95% <0%> (-0.13%) ⬇️
exporter/stackdriverexporter/factory.go 7.14% <7.14%> (ø)
exporter/opencensusexporter/opencensus.go 72.22% <0%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea50ba4...7b597b4. Read the comment docs.

@pjanotti
Copy link
Contributor

pjanotti commented Jul 8, 2019

Hi @inigohu thanks for the PR.

We still have to setup the contrib repo for OpenTelemetry Service. Per discussion #13 only a small set of receivers/exporters are going to be part of the core. Please, check the planned migration path from OC Service to OTel Service at https://github.com/open-telemetry/opentelemetry-service/blob/master/docs/migrating-from-opencensus.md

@inigohu
Copy link
Contributor Author

inigohu commented Jul 9, 2019

Hi @inigohu thanks for the PR.

We still have to setup the contrib repo for OpenTelemetry Service. Per discussion #13 only a small set of receivers/exporters are going to be part of the core. Please, check the planned migration path from OC Service to OTel Service at https://github.com/open-telemetry/opentelemetry-service/blob/master/docs/migrating-from-opencensus.md

OK, I didn't see that.

@inigohu inigohu closed this Jul 9, 2019
@inigohu inigohu deleted the feature/stackdriver-exporter branch September 19, 2019 14:30
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Define full schema for opentelemetry-collector helm chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants